Port to Tokio 0.2 by vorot93 · Pull Request #307 · http-rs/tide

vorot93 · 2019-08-16T15:04:40Z

Quickly sew this together to get started with Tokio 0.2 runtime. Due to an additional trait bound in http-service I cut Zstd support. Also I removed App::run, although I don't think it will really be missed since async main has become commonplace.

Tested locally, appears to be working.

fix cargo fmt loosen up clippy to warnings on examples snipe dev deps from core eliminate some clippy warnings for examples add publish false, and remove publish requirements rename tide-examples to just examples

Precursor: Tide core isolation revamp

Fix example link in readme

Rename `serve` to `run`, add asynchronous `serve`

Co-Authored-By: Wonwoo Choi <chwo9843@gmail.com>

Check example in readme compiles during testing

Remove #[allow(unused_mut)]

Middleware-based compression and decompression

Improve curl command consistency

* Move core traits and types to tide-core * Move cookies middleware to tide-cookies * Remove unncessary dependencies and use relative paths in README

* Update travis config * Separate out individual build jobs for faster wall-clock testing * Fix clippy not actually denying warnings (excluded examples because these are currently failing and have non-trivial fixes) * Add build job that checks --no-default-features works * Add build job that checks for intra-doc-resolution failures (excluded tide because of bugs in re-exports with the intra-doc feature) * Fix warnings * Fix doc-link in tide-cookies

as follows #187

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>

…n header

CORS middleware: better handling of Origin

yoshuawuyts

Overall this looks good, but I think we can probably change out the git deps now that a new http-service has been published!

yoshuawuyts · 2019-09-02T10:40:43Z

Cargo.toml

-http-service = "0.3.1"
-http-service-hyper = { version = "0.3.1", optional = true }
+http-service = { git = "https://github.com/rustasync/http-service", branch = "tokio-0.2" }
+http-service-hyper = { git = "https://github.com/rustasync/http-service", branch = "tokio-0.2", optional = true }


Is this still needed? I believe we already published updated versions right?

If you look closely, this actually depends on the branch. Specifically, this one:

http-rs/http-service#43

Besides, that branch depends upon git hyper anyway.

0.3.1 was supposed to release earlier, but I only got it done today after seeing http-rs/http-service#45

Is there a reason we aren't using overrides for the Git dependencies in this branch? (Seems that would prevent issues with publishing, but correct me if I'm wrong.)

Not sure -- Git deps can't be published to crates.io either way.

Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version. - [Release notes](https://github.com/sebasmagri/env_logger/releases) - [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.6.1...v0.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

abonander · 2019-09-25T19:10:52Z

What's the status on this? I wanted to see if my refactor on master of multipart-async was suitable for solving #89 yet but I built it against futures-*-preview 0.3.0-alpha.18 and I don't really want to downgrade (although I can if necessary).

Updates the requirements on [juniper](https://github.com/graphql-rust/juniper) to permit the latest version. - [Release notes](https://github.com/graphql-rust/juniper/releases) - [Commits](graphql-rust/juniper@juniper-0.13.1...juniper-v0.14.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

secretfader · 2019-10-29T22:14:09Z

I removed the example that required runtime in dfbaf72 a few moments ago, which should make wrapping up this PR a little bit easier. Feel free to rebase against master at your discretion @vorot93.

If you need help, I'm now available to help push this over the finish line.

vorot93 · 2019-10-31T12:30:13Z

@secretfader It looks like the whole repository has been ripped inside out. This PR should be redone from scratch now. Even then I'm not sure that things won't break again in the process.

yoshuawuyts · 2019-10-31T14:34:36Z

@vorot93 hi! I'm currently working on rebasing past commits based on a single repo; this may take a few days. Thanks so much for the work you've done, and apologies for the inconvenience! -- I'm hoping we can take the work that was done here and land it again soonish!

abonander · 2019-11-11T22:40:55Z

Should this be closed now? https://www.reddit.com/r/rust/comments/duvdzz/announcing_asyncstd_10/f79oba0/

tyranron · 2019-11-12T07:03:46Z

@abonander @yoshuawuyts why? Would you be so kind to explain the situation?

abonander · 2019-11-12T07:08:26Z

I'm only somewhat familiar with the circumstances. @yoshuawuyts can explain much better than I can.

tyranron · 2019-11-12T07:51:14Z

@abonander if so, why do you propose to close this PR referring only to a comment where author says he is banned? Is his work negligible or undesirable? From what I see in this PR it was sorta ongoing and OK, and then suddenly closed without any explanation 😕

abonander · 2019-11-12T08:14:51Z

The tone of the author's comment in that thread implies they don't have access to the PR/repo to complete it and/or have no interest in finishing it. Giving any more detail means entering a discussion I have no desire to partake in. It was my comment they replied to so I felt obliged to acknowledge it.

tyranron · 2019-11-12T09:37:54Z

@abonander thanks for making this clear.

yoshuawuyts · 2019-11-12T12:23:14Z

@tyranron the behavior of several individuals in withoutboats/romio#106 but also through other outlets (dms, forums, repos) has been disappointing and below the standards we expect for community participation. This has been the reason why they've lost the privilege of publicly engaging on repositories that are part of this organization.

Regarding upgrading to a modern runtime. That has already been implemented as part of #350, and I'll be kicking off the series of PRs required for a new release over the course of this week.

tyranron · 2019-11-12T13:28:57Z

@yoshuawuyts I've followed through the comments in withoutboats/romio#106 and in relevant Reddit posts, but clearly don't see any bad or disappointing behavior of @vorot93. I'm no one to judge your community standards, but the whole situation with banning contributors feels rather disappointing and even quite awkward.

Anyway, thanks for the clarification. And I'm finishing this offtopic.

rubik · 2020-10-02T06:35:15Z

@yoshuawuyts I'm very late to the discussion, could you clarify if Tokio is/will be supported at all? I cannot find any mention of it in the README. I really like tide and I would like to use it for my projects, but there are some other libraries that only work with Tokio (Elasticsearch). My understanding is that mixing two runtimes is problematic, so it would be great if tide worked with Tokio as well.

yoshuawuyts · 2020-10-02T08:04:12Z

@rubik async-std comes with a tokio02 feature flag that makes Tokio play nice with other runtimes. Using that should make it possible to use Tokio crates with Tide.

rubik · 2020-10-02T12:32:41Z

@yoshuawuyts Ahh I did not know that. Thanks a lot! That's very promising!

prasannavl and others added 30 commits May 15, 2019 06:51

isolate core revamp

d67ec8f

fix cargo fmt loosen up clippy to warnings on examples snipe dev deps from core eliminate some clippy warnings for examples add publish false, and remove publish requirements rename tide-examples to just examples

Merge pull request #219 from prasannavl/2019_05_tide_isolate_core

a50668f

Precursor: Tide core isolation revamp

Fix example link in readme

a376d60

Merge pull request #221 from daleione/readme

c3066f7

Fix example link in readme

fix broken links in readme

be577ef

Rename serve to run, add asynchronous serve

f4473d6

Run rustfmt

6078fc4

add tide-compression crate

059a8f8

Merge pull request #203 from tirr-c/serve-future

77dd922

Rename `serve` to `run`, add asynchronous `serve`

Merge remote-tracking branch 'upstream/master' into compression

250c2b9

use run instead of serve

80f0af6

Update tide-compression/README.md

962fddc

Co-Authored-By: Wonwoo Choi <chwo9843@gmail.com>

Check example in readme compiles during testing

b19eb2e

Remove #[allow(unused_mut)]

3af12d9

Merge pull request #229 from Nemo157/test-readme

f7ba837

Check example in readme compiles during testing

Remove #[allow(unused_mut)] (#231)

dac4493

Remove #[allow(unused_mut)]

Merge remote-tracking branch 'upstream/master' into compression

29cdf99

Middleware-based compression and decompression (#194)

d64d063

Middleware-based compression and decompression

Improve curl command consistency

4531977

Improve curl command consistency (#233)

bdc9fdf

Improve curl command consistency

Split tide into smaller crates (#220)

77b3a1c

* Move core traits and types to tide-core * Move cookies middleware to tide-cookies * Remove unncessary dependencies and use relative paths in README

add tide-log

e7a7dac

change deny attr to warn; consistent enforcement for all crates

1106a85

Add ResultDynErrExt (#216)

2878aba

remove remaining deny attrs

4d6da98

rename trait ExtractForms to ContextExt (#239)

011d0db

as follows #187

remove async box macro

6637aaf

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>

rustfmt

e7703fd

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>

Fix broken links in readme (#242)

4806db4

taiki-e and others added 6 commits August 22, 2019 01:09

Update slog-stdlog to 4.0 (#314)

c41ed84

CORS middleware: no origin header should be treated as an empty origi…

336c6ef

…n header

CORS middleware: update test

f56a27d

CORS middleware: fix clippy

87807a7

Merge pull request #318 from Ivshti/master

67e9191

CORS middleware: better handling of Origin

updated runtime to 0.3.0-alpha.7, removed patch for crates.io (#319)

af0b900

yoshuawuyts requested changes Sep 2, 2019

View reviewed changes

dependabot-preview bot and others added 5 commits September 30, 2019 06:26

Port to Tokio 0.2

de9f51e

Remove external docs so as to build on beta

a69d98d

Remove feature flag

9f9bdd6

Cut the runtime example for now

2a9dede

yoshuawuyts force-pushed the master branch from dfbaf72 to 4a53890 Compare October 30, 2019 17:07

yoshuawuyts closed this Nov 11, 2019

Conversation

vorot93 commented Aug 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yoshuawuyts left a comment

Choose a reason for hiding this comment

Uh oh!

yoshuawuyts Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

vorot93 Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

secretfader Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

yoshuawuyts Sep 5, 2019

Choose a reason for hiding this comment

Uh oh!

abonander commented Sep 25, 2019

Uh oh!

secretfader commented Oct 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vorot93 commented Oct 31, 2019

Uh oh!

yoshuawuyts commented Oct 31, 2019

Uh oh!

abonander commented Nov 11, 2019

Uh oh!

tyranron commented Nov 12, 2019

Uh oh!

abonander commented Nov 12, 2019

Uh oh!

tyranron commented Nov 12, 2019

Uh oh!

abonander commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tyranron commented Nov 12, 2019

Uh oh!

yoshuawuyts commented Nov 12, 2019

Uh oh!

tyranron commented Nov 12, 2019

Uh oh!

rubik commented Oct 2, 2020

Uh oh!

yoshuawuyts commented Oct 2, 2020

Uh oh!

rubik commented Oct 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

vorot93 commented Aug 16, 2019 •

edited

Loading

vorot93 Sep 2, 2019 •

edited

Loading

secretfader commented Oct 29, 2019 •

edited

Loading

abonander commented Nov 12, 2019 •

edited

Loading