-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 4 vulnerabilities #11540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the security posture of the project by automatically updating specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThis PR updates dependency management for the fossa plugin by replacing workspace protocol references with pinned versions for two Backstage packages. The Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant PM as Package Manager
participant FP as FOSSA Plugin
participant CC as @backstage/core-components
participant TH as @backstage/theme
Note over PM,TH: Dependency Resolution Process
PM->>FP: Read package.json
FP-->>PM: Dependencies list
alt Before Change (workspace:^)
PM->>PM: Resolve workspace:^ references
PM->>PM: Use local workspace versions
Note over PM: Dynamic version from monorepo
else After Change (pinned versions)
PM->>CC: Fetch version 0.8.6
CC-->>PM: Package installed
PM->>TH: Fetch version 0.1.1
TH-->>PM: Package installed
Note over PM: Fixed versions from registry
end
PM->>FP: Dependencies installed
Note over FP: Plugin ready with<br/>pinned dependency versions
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix four security vulnerabilities by pinning @backstage/core-components and @backstage/theme to older, specific versions. However, this change is problematic in this monorepo as it breaks the workspace: protocol, which can lead to serious integration issues. I've left a comment with a recommendation to revert these changes and instead use yarn's resolutions feature to address the transitive dependency vulnerabilities without disrupting the monorepo structure. The PR also notes that yarn.lock was not updated, which would need to be addressed manually.
| "@backstage/core-components": "0.8.6", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change pins @backstage/core-components and @backstage/theme to specific, outdated versions, replacing the workspace:^ specifier. This is a critical issue in a monorepo as it breaks the workspace protocol, likely leading to dependency conflicts, build failures, or runtime errors due to API incompatibilities.
The pinned versions (0.8.6 and 0.1.1) are significant downgrades from the current workspace versions (0.13.4-next.0 and 0.4.1 respectively).
While this was likely done to fix security vulnerabilities, this approach is incorrect. A better way to fix transitive dependency vulnerabilities in a yarn workspace is to use resolutions in the root package.json. This allows you to override vulnerable nested dependencies without breaking the workspace linking.
I recommend reverting these changes and using resolutions to address the Snyk vulnerabilities.
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^"
Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/fossa/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
SNYK-JS-DIFF-14917201
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR pins Backstage dependencies in the fossa plugin to specific versions instead of using workspace protocol.
@backstage/core-componentsfromworkspace:^to0.8.6inplugins/fossa/package.json@backstage/themefromworkspace:^to0.1.1inplugins/fossa/package.json