Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 30, 2026

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/entity-feedback/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  129  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  61  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal


EntelligenceAI PR Summary

This PR pins dependency versions in the entity-feedback plugin package.json, replacing workspace protocol references with fixed version numbers.

  • Changed @backstage/core-components from workspace:^ to fixed version 0.8.6
  • Changed @backstage/plugin-entity-feedback-common from workspace:^ to fixed version 0.1.0
  • Indicates preparation for independent package publishing or version compatibility resolution

@codesandbox
Copy link

codesandbox bot commented Jan 30, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to bolster the project's security posture by automatically applying fixes for several medium-severity vulnerabilities detected in its yarn dependencies. The changes involve precise version bumps for two key Backstage-related packages, ensuring the project benefits from the latest security patches without introducing broad dependency changes.

Highlights

  • Vulnerability Remediation: This PR, automatically generated by Snyk, addresses four medium-severity vulnerabilities found in the project's yarn dependencies. These include Directory Traversal (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355), Regular Expression Denial of Service (SNYK-JS-DIFF-14917201), and Uncontrolled Recursion (SNYK-JS-ESLINT-15102420).
  • Dependency Version Updates: To resolve the identified vulnerabilities, the plugins/entity-feedback/package.json file has been updated. Specifically, @backstage/core-components is upgraded to version 0.8.6 and @backstage/plugin-entity-feedback-common is upgraded to 0.1.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 30, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm atob under CC-BY-3.0

License: CC-BY-3.0 - the applicable license policy does not allow this license (4) (package/LICENSE.DOCS)

From: ?npm/atob@2.1.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/atob@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This PR updates dependency management for the entity-feedback plugin by replacing workspace protocol references with fixed version numbers. Specifically, it pins @backstage/core-components to version 0.8.6 and @backstage/plugin-entity-feedback-common to version 0.1.0. This change moves away from monorepo workspace resolution (workspace:^) to explicit version pinning, which typically indicates preparation for independent package publication or resolution of version compatibility constraints within the Backstage ecosystem.

Changes

File(s) Summary
plugins/entity-feedback/package.json Replaced workspace protocol (workspace:^) with fixed versions for two dependencies: @backstage/core-components pinned to 0.8.6 and @backstage/plugin-entity-feedback-common pinned to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant EFP as entity-feedback plugin
    participant CC as @backstage/core-components
    participant PEFC as @backstage/plugin-entity-feedback-common
    
    Note over EFP,PEFC: Dependency Version Update
    
    EFP->>CC: depends on (changed to v0.8.6)
    Note right of CC: Previously: workspace:^<br/>Now: 0.8.6 (pinned)
    
    EFP->>PEFC: depends on (changed to v0.1.0)
    Note right of PEFC: Previously: workspace:^<br/>Now: 0.1.0 (pinned)
    
    Note over EFP,PEFC: No runtime behavior changes<br/>Only dependency version pinning
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix four security vulnerabilities by pinning two dependencies in plugins/entity-feedback/package.json to older, specific versions. However, this approach is problematic for a monorepo using Yarn workspaces. Replacing workspace:^ with fixed versions like 0.8.6 and 0.1.0 is a significant downgrade and will likely lead to build failures or runtime errors due to dependency conflicts. I've added a critical comment with a suggestion to revert this change and have outlined a more appropriate way to resolve these vulnerabilities within the monorepo structure.

Comment on lines +31 to +35
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^",
"@backstage/plugin-entity-feedback-common": "0.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning dependencies to specific, older versions (0.8.6 for @backstage/core-components and 0.1.0 for @backstage/plugin-entity-feedback-common) instead of using workspace:^ is problematic in this monorepo setup. This change will likely cause build failures or runtime issues due to version mismatches with other packages in the workspace. The workspace versions are 0.13.4-next.0 and 0.1.1 respectively, so this is a significant downgrade.

Instead of accepting this change, the underlying vulnerabilities should be addressed differently. Since the vulnerabilities seem to be in development-related transitive dependencies, you could try running yarn upgrade-interactive to update the lockfile, or use yarn why <vulnerable-package> to trace the dependency and use resolutions in the root package.json to force a non-vulnerable version of the transitive dependency across the workspace. Merging this as-is is not recommended.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-entity-feedback-common": "workspace:^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants