-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 4 vulnerabilities #11542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to bolster the project's security posture by automatically applying fixes for several medium-severity vulnerabilities detected in its yarn dependencies. The changes involve precise version bumps for two key Backstage-related packages, ensuring the project benefits from the latest security patches without introducing broad dependency changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
WalkthroughThis PR updates dependency management for the entity-feedback plugin by replacing workspace protocol references with fixed version numbers. Specifically, it pins Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant EFP as entity-feedback plugin
participant CC as @backstage/core-components
participant PEFC as @backstage/plugin-entity-feedback-common
Note over EFP,PEFC: Dependency Version Update
EFP->>CC: depends on (changed to v0.8.6)
Note right of CC: Previously: workspace:^<br/>Now: 0.8.6 (pinned)
EFP->>PEFC: depends on (changed to v0.1.0)
Note right of PEFC: Previously: workspace:^<br/>Now: 0.1.0 (pinned)
Note over EFP,PEFC: No runtime behavior changes<br/>Only dependency version pinning
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix four security vulnerabilities by pinning two dependencies in plugins/entity-feedback/package.json to older, specific versions. However, this approach is problematic for a monorepo using Yarn workspaces. Replacing workspace:^ with fixed versions like 0.8.6 and 0.1.0 is a significant downgrade and will likely lead to build failures or runtime errors due to dependency conflicts. I've added a critical comment with a suggestion to revert this change and have outlined a more appropriate way to resolve these vulnerabilities within the monorepo structure.
| "@backstage/core-components": "0.8.6", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/plugin-entity-feedback-common": "workspace:^", | ||
| "@backstage/plugin-entity-feedback-common": "0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning dependencies to specific, older versions (0.8.6 for @backstage/core-components and 0.1.0 for @backstage/plugin-entity-feedback-common) instead of using workspace:^ is problematic in this monorepo setup. This change will likely cause build failures or runtime issues due to version mismatches with other packages in the workspace. The workspace versions are 0.13.4-next.0 and 0.1.1 respectively, so this is a significant downgrade.
Instead of accepting this change, the underlying vulnerabilities should be addressed differently. Since the vulnerabilities seem to be in development-related transitive dependencies, you could try running yarn upgrade-interactive to update the lockfile, or use yarn why <vulnerable-package> to trace the dependency and use resolutions in the root package.json to force a non-vulnerable version of the transitive dependency across the workspace. Merging this as-is is not recommended.
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^"
Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/entity-feedback/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
SNYK-JS-DIFF-14917201
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR pins dependency versions in the entity-feedback plugin package.json, replacing workspace protocol references with fixed version numbers.
@backstage/core-componentsfromworkspace:^to fixed version0.8.6@backstage/plugin-entity-feedback-commonfromworkspace:^to fixed version0.1.0