Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 30, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/search-common/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  129  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

Updates dependency specification for @backstage/types in the search-common plugin from workspace reference to a fixed version.

  • Changed dependency version from workspace:^ to 0.1.1 in plugins/search-common/package.json
  • Transitions from monorepo workspace dependency to external published package dependency
  • Pins package to specific version rather than using local workspace version
  • May indicate package publishing or modularization effort

@codesandbox
Copy link

codesandbox bot commented Jan 30, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading the @backstage/types dependency. The update specifically targets and resolves three identified medium-severity vulnerabilities, improving the overall security posture of the application.

Highlights

  • Dependency Upgrade: The @backstage/types dependency has been upgraded from 0.0.0-use.local (implied by workspace:^) to 0.1.1 in plugins/search-common/package.json.
  • Security Fixes: This upgrade addresses three medium-severity vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355) and one Uncontrolled Recursion issue (SNYK-JS-ESLINT-15102420).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 30, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm atob under CC-BY-3.0

License: CC-BY-3.0 - the applicable license policy does not allow this license (4) (package/LICENSE.DOCS)

From: ?npm/atob@2.1.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/atob@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This pull request updates the dependency management for the @backstage/types package in the search-common plugin. The change transitions from using a workspace protocol reference to a pinned version dependency. Specifically, the dependency specification changes from workspace:^ to version 0.1.1, which indicates a shift from relying on the local monorepo workspace version to depending on a specific published package version. This modification affects how the package dependency is resolved and may be part of a broader effort to publish packages independently or restructure the monorepo's dependency management strategy.

Changes

File(s) Summary
plugins/search-common/package.json Changed @backstage/types dependency from workspace protocol reference (workspace:^) to fixed version 0.1.1, pinning to a specific published package version.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant WS as Workspace
    participant NPM as NPM Registry
    
    Note over Dev,NPM: Dependency Resolution Change
    
    Dev->>PM: Update package.json
    Note right of Dev: Change @backstage/types<br/>from workspace:^ to 0.1.1
    
    alt Before Change (workspace:^)
        PM->>WS: Resolve @backstage/types
        WS-->>PM: Return local workspace package
    else After Change (0.1.1)
        PM->>NPM: Fetch @backstage/types@0.1.1
        NPM-->>PM: Return published package version
    end
    
    PM->>Dev: Dependencies resolved
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to address security vulnerabilities by upgrading the @backstage/types dependency to version 0.1.1. While the package.json has been updated, it's crucial to ensure the yarn.lock file is also updated to reflect this change. The PR description indicates that yarn.lock failed to update, which means the security fixes might not be fully applied, and build consistency could be compromised. Please manually update yarn.lock before merging.

"dependencies": {
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The package.json correctly updates @backstage/types to 0.1.1. However, the pull request description states that yarn.lock failed to update. For this security upgrade to be effective and to ensure consistent builds, the yarn.lock file must be manually updated to reflect this dependency change. Without an updated yarn.lock, the project might not use the intended secure version, leaving the vulnerabilities unaddressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants