Skip to content

[Snyk] Fix for 3 vulnerabilities #11545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/playlist-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +25 to +32
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly pins dependencies to specific versions instead of using workspace:^. In a Yarn workspace monorepo, this is a critical issue as it breaks the unified dependency resolution, forcing this package to use different versions of internal packages than the rest of the application. This can lead to hard-to-debug runtime errors, type inconsistencies, and build failures.

The correct way to address the Snyk-reported vulnerabilities is to manually update the vulnerable packages. The suggested course of action is:

  1. Revert the changes in this pull request.
  2. Identify which workspace packages depend on the vulnerable versions of tar and eslint.
  3. Update those dependencies in their respective package.json files.
  4. Run yarn install to update the yarn.lock file.

The code suggestion below reverts these changes.

    "@backstage/backend-common": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-node": "workspace:^"

"@backstage/plugin-playlist-common": "workspace:^",
"@types/express": "*",
"express": "^4.17.1",
Expand Down
Loading