Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 31, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/techdocs-node/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  129  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

This PR pins Backstage dependencies to specific versions in the techdocs-node plugin package configuration.

  • Changed @backstage/backend-common from workspace:^ to fixed version 0.24.1
  • Changed @backstage/plugin-search-common from workspace:^ to fixed version 0.3.1
  • Transitions from monorepo workspace references to explicit version specifications
  • Modified in plugins/techdocs-node/package.json

@codesandbox
Copy link

codesandbox bot commented Jan 31, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving critical vulnerabilities within its yarn dependencies. It specifically targets and mitigates Directory Traversal and Uncontrolled Recursion issues by updating key @backstage packages, ensuring a more secure and stable dependency landscape.

Highlights

  • Security Vulnerability Fixes: This PR addresses three security vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355) and one Uncontrolled Recursion issue (SNYK-JS-ESLINT-15102420).
  • Dependency Upgrades: The fix involves upgrading @backstage/backend-common to 0.24.1 and @backstage/plugin-search-common to 0.3.1 in plugins/techdocs-node/package.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 31, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This PR updates dependency management for the techdocs-node plugin by transitioning from workspace protocol references to fixed version specifications. Two Backstage packages are affected: @backstage/backend-common is pinned to version 0.24.1 and @backstage/plugin-search-common is pinned to version 0.3.1. This change replaces the flexible workspace:^ protocol with explicit version numbers, indicating a shift from monorepo workspace dependencies to published package versions. This modification is typically performed when preparing a package for independent publication or when establishing stricter version control for dependency management.

Changes

File(s) Summary
plugins/techdocs-node/package.json Updated dependency specifications from workspace protocol (workspace:^) to fixed versions: @backstage/backend-common to 0.24.1 and @backstage/plugin-search-common to 0.3.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Deps as Dependencies
    
    Note over Dev,Deps: Dependency Version Update Process
    
    Dev->>PM: Update package.json
    Note right of Dev: Pin @backstage/backend-common to 0.24.1<br/>Pin @backstage/plugin-search-common to 0.3.1
    
    PM->>Deps: Resolve dependencies
    Deps-->>PM: Return specific versions
    
    PM->>PM: Install pinned versions
    Note over PM: Replace workspace references<br/>with fixed versions
    
    PM-->>Dev: Dependencies updated
    
    Note over Dev,Deps: No runtime behavior changes<br/>Only build-time dependency resolution affected
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Snyk aims to fix three security vulnerabilities by pinning two @backstage dependencies to specific versions. While the intent is good, the pull request is incomplete as it's missing the yarn.lock update, which is a critical part of the fix. Additionally, pinning workspace dependencies to registry versions is a workaround that breaks the monorepo development flow and should be avoided in favor of a more integrated fix. My review includes a critical comment about the missing lockfile and a high-severity comment explaining the issue with pinning and suggesting a better approach.

Comment on lines +49 to +55
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The PR description correctly warns that yarn.lock has not been updated. Without the lockfile update, these dependency changes will not be resolved correctly, and the security vulnerabilities will persist. Before merging, please run yarn install (or equivalent) and commit the updated yarn.lock file.

Comment on lines +49 to +55
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning workspace packages like @backstage/backend-common and @backstage/plugin-search-common to specific versions from the registry breaks the monorepo development workflow. This means local changes in those packages will be ignored when working on techdocs-node, which can lead to confusion and bugs.

While this might be a quick way to fix a security issue, it's a workaround. The proper fix is to update the dependency that introduces the vulnerability, while keeping the workspace:^ reference. You can use yarn why <vulnerable-package> to trace the dependency path.

If this is intended as a temporary hotfix, I recommend creating a follow-up ticket to address this properly. For a permanent fix, the workspace: protocol should be restored.

    "@backstage/backend-common": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/integration-aws-node": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants