-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 4 vulnerabilities #11563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving four identified medium-severity vulnerabilities. It achieves this by updating specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by modifying dependencies. However, the proposed changes in plugins/nomad/package.json are incorrect and will likely break the application. It replaces workspace-linked dependencies (workspace:^) with very old, hardcoded versions of core Backstage packages. This approach is incompatible with the monorepo structure and will lead to version conflicts and runtime errors. The fact that Snyk failed to update the yarn.lock file is another strong indicator that these changes are problematic. The vulnerabilities should be addressed by other means, such as using Yarn's resolutions feature to update the vulnerable transitive dependencies, or by updating the root packages that bring in these dependencies. I recommend rejecting this pull request.
| "@backstage/core-components": "0.8.6", | ||
| "@backstage/core-plugin-api": "0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning @backstage/core-components and @backstage/core-plugin-api to old, specific versions is incorrect and will likely break the build or cause runtime errors. This project uses a monorepo structure with Yarn workspaces, and dependencies between packages within the monorepo should use workspace:^ to ensure they all use the same, consistent version.
Replacing workspace:^ with hardcoded versions (0.8.6 and 0.1.0) is a significant downgrade from the versions available in this repository (0.13.4-next.0 and 1.5.3 respectively) and will introduce version mismatches and API incompatibilities.
The correct way to fix the underlying security vulnerabilities is to either update the root packages to versions that use non-vulnerable transitive dependencies, or to use the resolutions field in the root package.json to force an upgrade of the specific vulnerable packages (e.g., tar, diff, eslint).
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the Nomad plugin by replacing workspace protocol references with fixed version numbers for two Backstage core packages. The Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Workspace as Workspace Packages
participant NPM as NPM Registry
participant Nomad as Nomad Plugin
Note over Dev,Nomad: Before: Using workspace protocol
Dev->>PM: Install dependencies
PM->>Workspace: Resolve workspace:^ dependencies
Workspace-->>PM: Return local core-components & core-plugin-api
PM->>Nomad: Link local packages
Note over Dev,Nomad: After: Using fixed versions
Dev->>PM: Install dependencies
PM->>NPM: Fetch @backstage/core-components@0.8.6
NPM-->>PM: Return published package
PM->>NPM: Fetch @backstage/core-plugin-api@0.1.0
NPM-->>PM: Return published package
PM->>Nomad: Install fixed version packages
Note over Nomad: Now uses specific published versions<br/>instead of local workspace packages
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/nomad/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
SNYK-JS-DIFF-14917201
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR transitions the Nomad plugin from workspace protocol dependencies to fixed version dependencies for Backstage core packages.
@backstage/core-componentsfrom workspace protocol to version0.8.6@backstage/core-plugin-apifrom workspace protocol to version0.1.0plugins/nomad/package.json