Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 31, 2026

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/nomad/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  61  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Directory Traversal


EntelligenceAI PR Summary

This PR transitions the Nomad plugin from workspace protocol dependencies to fixed version dependencies for Backstage core packages.

  • Changed @backstage/core-components from workspace protocol to version 0.8.6
  • Changed @backstage/core-plugin-api from workspace protocol to version 0.1.0
  • Modified dependency resolution strategy in plugins/nomad/package.json
  • Enables consumption of published package versions instead of local monorepo references

@codesandbox
Copy link

codesandbox bot commented Jan 31, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving four identified medium-severity vulnerabilities. It achieves this by updating specific @backstage dependencies within the plugins/nomad module, thereby mitigating risks associated with directory traversal, regular expression denial of service, and uncontrolled recursion.

Highlights

  • Vulnerability Fixes: This pull request addresses four medium-severity vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355), one Regular Expression Denial of Service (SNYK-JS-DIFF-14917201), and one Uncontrolled Recursion (SNYK-JS-ESLINT-15102420).
  • Dependency Updates: The fix involves updating @backstage/core-components from workspace:^ to 0.8.6 and @backstage/core-plugin-api from workspace:^ to 0.1.0 in the plugins/nomad/package.json file.
  • Manual yarn.lock Update Required: The PR explicitly notes that the yarn.lock file was not updated automatically and requires manual intervention before merging, particularly for users leveraging Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 31, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by modifying dependencies. However, the proposed changes in plugins/nomad/package.json are incorrect and will likely break the application. It replaces workspace-linked dependencies (workspace:^) with very old, hardcoded versions of core Backstage packages. This approach is incompatible with the monorepo structure and will lead to version conflicts and runtime errors. The fact that Snyk failed to update the yarn.lock file is another strong indicator that these changes are problematic. The vulnerabilities should be addressed by other means, such as using Yarn's resolutions feature to update the vulnerable transitive dependencies, or by updating the root packages that bring in these dependencies. I recommend rejecting this pull request.

Comment on lines +27 to +28
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/core-components and @backstage/core-plugin-api to old, specific versions is incorrect and will likely break the build or cause runtime errors. This project uses a monorepo structure with Yarn workspaces, and dependencies between packages within the monorepo should use workspace:^ to ensure they all use the same, consistent version.

Replacing workspace:^ with hardcoded versions (0.8.6 and 0.1.0) is a significant downgrade from the versions available in this repository (0.13.4-next.0 and 1.5.3 respectively) and will introduce version mismatches and API incompatibilities.

The correct way to fix the underlying security vulnerabilities is to either update the root packages to versions that use non-vulnerable transitive dependencies, or to use the resolutions field in the root package.json to force an upgrade of the specific vulnerable packages (e.g., tar, diff, eslint).

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This PR updates the dependency management strategy for the Nomad plugin by replacing workspace protocol references with fixed version numbers for two Backstage core packages. The @backstage/core-components package is now pinned to version 0.8.6 and @backstage/core-plugin-api is pinned to version 0.1.0. This transition from workspace protocol to explicit version pinning suggests the plugin is moving away from local monorepo dependency resolution to consuming published package versions, which will affect how dependencies are resolved during installation and may impact the plugin's distribution and deployment strategy.

Changes

File(s) Summary
plugins/nomad/package.json Updated dependency specifications from workspace protocol to fixed versions: @backstage/core-components pinned to 0.8.6 and @backstage/core-plugin-api pinned to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Workspace as Workspace Packages
    participant NPM as NPM Registry
    participant Nomad as Nomad Plugin

    Note over Dev,Nomad: Before: Using workspace protocol

    Dev->>PM: Install dependencies
    PM->>Workspace: Resolve workspace:^ dependencies
    Workspace-->>PM: Return local core-components & core-plugin-api
    PM->>Nomad: Link local packages

    Note over Dev,Nomad: After: Using fixed versions

    Dev->>PM: Install dependencies
    PM->>NPM: Fetch @backstage/core-components@0.8.6
    NPM-->>PM: Return published package
    PM->>NPM: Fetch @backstage/core-plugin-api@0.1.0
    NPM-->>PM: Return published package
    PM->>Nomad: Install fixed version packages
    
    Note over Nomad: Now uses specific published versions<br/>instead of local workspace packages
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants