Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 31, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/backend-app-api/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

This PR transitions the backend-app-api package from workspace protocol dependencies to pinned version numbers for five Backstage packages.

  • Changed @backstage/backend-common from workspace:^ to 0.24.1
  • Changed @backstage/backend-plugin-api from workspace:^ to 0.1.0
  • Changed @backstage/config-loader from workspace:^ to 0.1.1
  • Changed @backstage/plugin-auth-node from workspace:^ to 0.1.0
  • Changed @backstage/plugin-permission-node from workspace:^ to 0.1.0
  • Indicates transition from monorepo workspace dependency management to explicit version pinning

@codesandbox
Copy link

codesandbox bot commented Jan 31, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving three identified vulnerabilities within its yarn dependencies. It achieves this by upgrading specific @backstage packages in the packages/backend-app-api module, mitigating risks associated with directory traversal and uncontrolled recursion.

Highlights

  • Vulnerability Fixes: This pull request addresses three security vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355) and one Uncontrolled Recursion issue (SNYK-JS-ESLINT-15102420).
  • Dependency Upgrades: Several @backstage dependencies in packages/backend-app-api/package.json have been upgraded to newer versions to resolve the identified vulnerabilities. Specifically, @backstage/backend-common was updated to 0.24.1, @backstage/backend-plugin-api to 0.1.0, @backstage/config-loader to 0.1.1, @backstage/plugin-auth-node to 0.1.0, and @backstage/plugin-permission-node to 0.1.0.
  • Manual yarn.lock Update Required: The yarn.lock file was not automatically updated by Snyk and requires manual intervention after merging, particularly for users leveraging Yarn's zero-install feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 31, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix three security vulnerabilities by updating dependencies. However, the proposed changes are problematic. They replace workspace: dependencies with pinned, and in most cases, significantly older versions of packages. This will likely break the build and is not the correct way to manage dependencies in this monorepo. Furthermore, the yarn.lock file has not been updated as noted in the PR description. I've left a critical comment on the package.json file explaining the issue. The PR should be rejected in its current state, and the vulnerabilities should be addressed by correctly updating dependencies within the workspace.

Comment on lines +35 to +43
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/backend-tasks": "workspace:^",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-permission-node": "0.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency updates from Snyk seem incorrect and will likely break the build. Most of these changes are downgrading packages to very old versions instead of updating them. For example, @backstage/backend-plugin-api is being downgraded from a workspace version (currently 0.5.5-next.0) to 0.1.0.

This approach breaks the workspace: protocol used in this monorepo. The correct way to fix these vulnerabilities is to update the package versions within the workspace itself, not to pin them to arbitrary, outdated versions.

Additionally, the PR description warns that yarn.lock was not updated. This is a critical omission that would prevent these changes from being applied correctly and could cause inconsistencies.

Due to these issues, I recommend rejecting this automated pull request and addressing the vulnerabilities manually by properly updating the workspace packages.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This pull request updates the dependency management strategy for the backend-app-api package by replacing workspace protocol references with explicit version numbers. Five Backstage packages are affected: backend-common (0.24.1), backend-plugin-api (0.1.0), config-loader (0.1.1), plugin-auth-node (0.1.0), and plugin-permission-node (0.1.0). This transition from workspace:^ to pinned versions suggests preparation for package publication or a move toward more stable dependency management outside of a monorepo workspace context.

Changes

File(s) Summary
packages/backend-app-api/package.json Updated five Backstage package dependencies from workspace protocol (workspace:^) to explicit version numbers: @backstage/backend-common to 0.24.1, @backstage/backend-plugin-api to 0.1.0, @backstage/config-loader to 0.1.1, @backstage/plugin-auth-node to 0.1.0, and @backstage/plugin-permission-node to 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PKG as package.json
    participant WS as Workspace Dependencies
    participant NPM as NPM Registry

    Note over Dev,NPM: Dependency Resolution Change

    Dev->>PKG: Update dependency versions
    
    alt Before Change (workspace:^)
        PKG->>WS: Resolve @backstage/backend-common
        WS-->>PKG: Return local workspace version
    else After Change (0.24.1)
        PKG->>NPM: Resolve @backstage/backend-common@0.24.1
        NPM-->>PKG: Return published version 0.24.1
    end

    Note over PKG,NPM: Same pattern for:<br/>- backend-plugin-api (0.1.0)<br/>- config-loader (0.1.1)<br/>- plugin-auth-node (0.1.0)<br/>- plugin-permission-node (0.1.0)
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants