fix(security): pin Docker base images by SHA, fix Scorecard publish failure#39
Merged
Merged
Conversation
…blish - Pin python:3.12-slim, node:20-alpine, nginx:1.25-alpine to SHA256 digests to address Scorecard PinnedDependencies findings - Disable publish_results in Scorecard workflow because sigstore imposter- commit checks reject SHA-pinned action references (the SARIF still uploads to GitHub code scanning so findings remain visible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #37. Addresses remaining OpenSSF Scorecard findings around container image pinning, and fixes the Scorecard workflow itself which was failing due to an imposter-commit check.
Changes
ode:20-alpine,
ginx:1.25-alpine to SHA256 digests in Dockerfiles
Why disable publish_results
The Scorecard webapp uses sigstore-based imposter-commit verification. Because we pin actions by SHA (per their own recommendation), the verification fails with HTTP 400. The SARIF still uploads to GitHub code scanning, so findings remain visible in the Security tab.