fix issue 4055#4058
Open
legionGIT wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in PartialState._prepare_backend where the SDAA device check (is_sdaa_available()) used a standalone if instead of elif, causing it to always evaluate independently of the MLU check above it.
When both MLU and SDAA conditions could be true, the SDAA branch would overwrite the previously set backend = "cncl" and distributed_type = MULTI_MLU with backend = "tccl" and distributed_type = MULTI_SDAA, incorrectly overriding the MLU backend selection.
The fix changes if is_sdaa_available() → elif is_sdaa_available() so it properly chains with the existing if is_mlu_available() / elif is_musa_available() / elif is_npu_available() / elif is_xpu_available() / elif is_mlu_available() conditional chain, ensuring only
one backend is selected.
Fixes #4055
Checklist