Add register_tracker_class() for custom tracker registration by name#4061
Open
devangpratap wants to merge 1 commit into
Open
Add register_tracker_class() for custom tracker registration by name#4061devangpratap wants to merge 1 commit into
register_tracker_class() for custom tracker registration by name#4061devangpratap wants to merge 1 commit into
Conversation
Allow custom tracker classes to be used by string name in log_with and init_trackers, matching built-in tracker behavior. Exposed both as a module-level function and as Accelerator.register_tracker_class(). Fixes huggingface#2734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
register_tracker_class()so custom tracker classes can be passed by string name tolog_withandinit_trackers, matching built-in tracker behavior. Previously users had to pass pre-instantiated tracker objects.Also exposed as
Accelerator.register_tracker_class()per the API discussed in the issue.Fixes #2734
Before submitting
Pull Request section?
to it if that's the case. [Feature Request] Allows registering custom trackers to internal tracker type registry #2734
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc @muellerzr