Raise ValueError instead of a bare string in ParallelismConfig.get_device_mesh#4064
Open
lollinng wants to merge 1 commit into
Open
Raise ValueError instead of a bare string in ParallelismConfig.get_device_mesh#4064lollinng wants to merge 1 commit into
lollinng wants to merge 1 commit into
Conversation
…mesh
get_device_mesh raised a string literal when device_type was not provided:
`raise ("You need to pass a device_type ...")`. In Python 3 raising a
non-exception throws `TypeError: exceptions must derive from BaseException`,
hiding the intended guidance. Raise ValueError with the message instead.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ParallelismConfig.get_device_meshraises a bare string whendevice_typeis missing:In Python 3 you can only raise exception instances, so this throws
TypeError: exceptions must derive from BaseExceptioninstead of surfacing theintended message — confusing for anyone who forgets to pass
device_type.Fix
Raise
ValueErrorwith the same message.Testing done (CPU)
ruffclean.