Conversation
This change fixes a small but important technical inconsistency in Chapter 2, Section 3 regarding tensor creation from tokenized sequences. The current example shows two encoded sequences of different lengths being directly converted into a PyTorch tensor and describes them as “already of rectangular shape.” In practice, PyTorch tensors require rectangular (uniform-length) inputs, and attempting to convert ragged sequences without padding raises a ValueError. This update clarifies that padding is required before conversion and aligns the example with actual PyTorch behavior and the tokenizer-based workflow introduced earlier in the section. The revised explanation helps avoid confusion for readers who try to run the code verbatim and reinforces the correct mental model: tokenization can produce variable-length sequences, but padding is necessary when creating tensors or passing inputs to a model.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Fix line wrapping to satisfy quality check
Karthika-ps
commented
Jan 12, 2026
Author
Karthika-ps
left a comment
There was a problem hiding this comment.
Fix line wrapping to satisfy quality check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a small but important technical inconsistency in Chapter 2, Section 3 regarding tensor creation from tokenized sequences.
The current example shows two encoded sequences of different lengths being directly converted into a PyTorch tensor and describes them as “already of rectangular shape.” In practice, PyTorch tensors require rectangular (uniform-length) inputs, and attempting to convert ragged sequences without padding raises a ValueError.
This update clarifies that padding is required before conversion and aligns the example with actual PyTorch behavior and the tokenizer-based workflow introduced earlier in the section. The revised explanation helps avoid confusion for readers who try to run the code verbatim and reinforces the correct mental model: tokenization can produce variable-length sequences, but padding is necessary when creating tensors or passing inputs to a model.