Skip to content

Add hash check for dynamic modules cache #13460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neo wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Add hash check for dynamic modules cache #13460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/diffusers/utils/dynamic_modules_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# limitations under the License.
"""Utilities to dynamically load objects from the Hub."""

import hashlib
import importlib
import inspect
import json
Expand Down Expand Up @@ -199,6 +200,10 @@ def get_class_in_module(class_name, module_path, force_reload=False):
cached_module: ModuleType | None = sys.modules.get(name)
module_spec = importlib.util.spec_from_file_location(name, location=module_file)

# Hash the module file and all its relative imports to check if we need to reload it
module_files: list[Path] = [module_file] + sorted(map(Path, get_relative_import_files(module_file)))
module_hash: str = hashlib.sha256(b"".join(bytes(f) + f.read_bytes() for f in module_files)).hexdigest()

module: ModuleType
if cached_module is None:
module = importlib.util.module_from_spec(module_spec)
Expand All @@ -207,7 +212,10 @@ def get_class_in_module(class_name, module_path, force_reload=False):
else:
module = cached_module

module_spec.loader.exec_module(module)
# reload in both cases, unless the module is already imported and the hash hits
if getattr(module, "__diffusers_module_hash__", "") != module_hash:
module_spec.loader.exec_module(module)
module.__diffusers_module_hash__ = module_hash

if class_name is None:
return find_pipeline_class(module)
Expand Down
Loading