Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Fix docker example#234

Closed
githubnemo wants to merge 1 commit intohuggingface:mainfrom
githubnemo:docs/fix-docker-command
Closed

Fix docker example#234
githubnemo wants to merge 1 commit intohuggingface:mainfrom
githubnemo:docs/fix-docker-command

Conversation

@githubnemo
Copy link

This is something I just stumbled upon when trying to get into building custom kernels.

The flake in this example (and others, didn't check all) reference kernel-builder via ../.. which will fail when only the flake is mounted into /app of the container. Mounting the whole repo and changing to the example directory in the container works, though.

The flake in this example (and others, didn't check all) reference
kernel-builder via `../..` which will fail when only the flake is
mounted into `/app` of the container. Mounting the whole repo
and changing to the example directory in the container works, though.
@danieldk danieldk requested a review from drbh September 29, 2025 07:53
@drbh
Copy link
Collaborator

drbh commented Oct 3, 2025

hey @githubnemo, thanks for the PR! While going through the changes and the overall Docker build flow, I spotted a few other small things that needed updates. I've opened a follow-up PR here: #239 once that’s merged, I think the build should be more straightforward and easy to run! Thanks again for surfacing this issue

@githubnemo
Copy link
Author

Cool, thanks! I'll close this PR then.

@githubnemo githubnemo closed this Oct 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants