This repository was archived by the owner on Jan 27, 2026. It is now read-only.
Conversation
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
MekkCyber
reviewed
Oct 3, 2025
Comment on lines
+158
to
+159
| # sm_101 has been renamed to sm_110 in CUDA 13. | ||
| "7.5;8.0;8.6;8.9;9.0;10.0;11.0;12.0"; |
Contributor
There was a problem hiding this comment.
do torch kernels not compile using cuda 13.0 on sm < 7.5 ? if so why are we keeping 7.0 in CUDA_DEFAULT_KERNEL_ARCHS
Member
Author
There was a problem hiding this comment.
Missed that, removed from CUDA_DEFAULT_KERNEL_ARCHS now 👍.
versions.nix
Outdated
Comment on lines
+141
to
+145
| torchVersion = "2.8"; | ||
| rocmVersion = "7.0.1"; | ||
| cxx11Abi = true; | ||
| systems = [ "x86_64-linux" ]; | ||
| bundleBuild = false; |
Contributor
There was a problem hiding this comment.
we can build torch 2.8 for 7.0.1 but not 2.9 ?
Member
Author
There was a problem hiding this comment.
I haven't tested it yet. This build variant was a one-off for Abdennacer to test with ROCm 7. I should probably remove it again, since it adds extra build time.
Member
Author
There was a problem hiding this comment.
Removed the ROCm 7 variant. We can add it once upstream PyTorch starts supporting it.
Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
MekkCyber
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds Torch 2.9 build variants to kernel-builder. Until the final release of Torch 2.9, the Torch 2.7 variants are also still built. The Torch 2.9 support is based on RC5, typically there are no ABI-incompatible changes at this point, but there is no guarantee.