Closed
Conversation
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Contributor
Author
|
Hi @danieldk @sywangyi . |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Contributor
Author
|
Hi @danieldk @drbh @MekkCyber . Could you please review this PR? Thanks! |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
MekkCyber
reviewed
Dec 4, 2025
Contributor
MekkCyber
left a comment
There was a problem hiding this comment.
Thanks @jiqing-feng lgtm ! sorry for the delay
Comment on lines
+1
to
+4
| [general] | ||
| name = "quantization_bitsandbytes" | ||
| universal = false | ||
|
|
Contributor
There was a problem hiding this comment.
this will change very very soon! I will let @danieldk make the final call to keep it or fix it for the new kernel-builder version
Member
There was a problem hiding this comment.
I think it's fine, since flake.lock pins everything. We can upgrade the build.tomls in one go once we have updated kernel-builder.
Member
|
CI in #80. |
danieldk
approved these changes
Dec 4, 2025
Member
|
Great work, very nice to have this! |
Member
|
Merged in #80. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CPU fused gemm_4bit kernel