Skip to content

Bnb#77

Closed
jiqing-feng wants to merge 21 commits intohuggingface:mainfrom
jiqing-feng:bnb
Closed

Bnb#77
jiqing-feng wants to merge 21 commits intohuggingface:mainfrom
jiqing-feng:bnb

Conversation

@jiqing-feng
Copy link
Contributor

@jiqing-feng jiqing-feng commented Nov 27, 2025

Enable CPU fused gemm_4bit kernel

Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
@jiqing-feng jiqing-feng marked this pull request as ready for review November 28, 2025 07:39
@jiqing-feng
Copy link
Contributor Author

Hi @danieldk @sywangyi .
As I removed __builtin_cpu_supports in this PR, so it will not rely on huggingface/kernel-builder#317. Please trigger the CI and review this PR. Thanks!

Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
@jiqing-feng
Copy link
Contributor Author

Hi @danieldk @drbh @MekkCyber . Could you please review this PR? Thanks!

Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiqing-feng lgtm ! sorry for the delay

Comment on lines +1 to +4
[general]
name = "quantization_bitsandbytes"
universal = false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will change very very soon! I will let @danieldk make the final call to keep it or fix it for the new kernel-builder version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, since flake.lock pins everything. We can upgrade the build.tomls in one go once we have updated kernel-builder.

@danieldk
Copy link
Member

danieldk commented Dec 4, 2025

CI in #80.

@danieldk
Copy link
Member

danieldk commented Dec 4, 2025

Great work, very nice to have this!

@danieldk
Copy link
Member

danieldk commented Dec 4, 2025

Merged in #80.

@danieldk danieldk closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants