feat(node): expose the pipeline encode path over napi - #2281
Open
ArthurZucker wants to merge 1 commit into
Open
Conversation
`Tokenizer.encode` goes through `encode_char_offsets`, so none of the pipeline work is reachable from Node. Two entry points, ids only, no offsets — and the return type chosen so marshalling doesn't eat the win: a `Vec<u32>` marshals as a boxed JS `Array`, one napi value per token, which costs 13× the encode itself on token-dense input.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokenizer.encodegoes throughencode_char_offsets, so none of the pipeline work is reachable from Node. Two entry points, ids only, no offsets.The boundary is the whole story once the encode is fast, so the shapes are picked around it:
encodereturns aUint32Arraybecause aVec<u32>marshals as a boxed JSArray(one napi value per token — 13× the encode itself on token-dense input), andencodeBytesIntodrops the two remaining per-call costs, the JS string → UTF-8 copy and the fresh ArrayBuffer.Bench
M4, single thread, 195 kB corpora, warm cache, ids verified equal to
Tokenizer.encodeon every cell:Boundary legs, gpt2 / 89 B: napi call 49 ns, JS string → UTF-8 109 ns, encode 250 ns, fresh
Uint32Array388 ns,Vec<u32>→ JSArray15 µs.encodeBytesIntolands at 379 ns against a 217 ns pure-Rust ceiling; the remaining ~110 ns is argument marshalling, which only batching removes.