Skip to content

fix(onnx): pass externalData to session_options when using customCache in Node.js #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-zx wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

fix(onnx): pass externalData to session_options when using customCache in Node.js #1600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c337e
fix(onnx): pass external data to session_options when using customCac…
jasonsss-ops Mar 21, 2026
32371fe
refactor: use instanceof Uint8Array instead of typeof !== 'string'
jasonsss-ops Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/transformers/src/models/session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,16 @@ async function getSession(
session_options,
);

if (externalData.length > 0 && !apis.IS_NODE_ENV) {
session_options.externalData = externalData;
if (externalData.length > 0) {
// In non-Node environments, always pass external data via session options.
// In Node.js with filesystem cache, the ONNX runtime locates external data
// files automatically relative to the model path, so we skip this.
// However, when using a custom cache (which returns Uint8Array instead of a
// file path), the ONNX runtime cannot find the files on disk, so we must
// supply the data in-memory via session_options.externalData.
if (!apis.IS_NODE_ENV || externalData.some(item => item instanceof Uint8Array)) {
session_options.externalData = externalData;
}
}

if (cache_config && selectedDevice === 'webgpu' && kv_cache_dtype_config !== false) {
Expand Down