Add Muse Glimmer support and testing - #6738
Open
qgallouedec wants to merge 3 commits into
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5de1b84. Configure here.
…t output_multiplier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Released 2026-08-10: meta-models/Muse-Glimmer-30B — Meta's Apache-2.0 agentic VLM (2B Perception Encoder + 28B dense text decoder), shipped in transformers 5.15.0.
muse_glimmer_for_conditional_generation.py(MuseGlimmerForConditionalGeneration), pinned totransformers==5.15.0. Keeps one layer of each type on both towers (text: sliding / full-attention, where full-attention layers are the NoPE ones vialayer_rope_theta0; vision: window / full-attention), and scalesout_hidden_sizetovision hidden_size * merge_size ** 2, which the vision adapter requires. Config diff vs the reference is 14 entries, all scale-downs.test_sft_trainer.py(3),test_dpo_trainer.py,test_kto_trainer.py.trl-internal-testing/tiny-MuseGlimmerForConditionalGeneration.Not in this PR: the chat template. Muse Glimmer ships a native
response_template, so parsing works out of the box, but the template has no{% generation %}markers — SFTassistant_only_loss=Trueneeds a vendored training variant, and its<atem:function_calls>tool syntax is a new family. Follow-up PR.Note
Medium Risk
Changes affect how scaled logits are applied in SFT chunked loss and distillation (including Liger guards) for VLMs; behavior is a targeted fallback but incorrect scaling would skew training objectives.
Overview
Adds Muse Glimmer (
MuseGlimmerForConditionalGeneration, transformers ≥5.15.0) to TRL’s tiny-model workflow and VLM test matrix.A new generator script builds a minimal checkpoint from
meta-models/Muse-Glimmer-30B(short text/vision stacks with sliding/window vs full-attention layers, scaledout_hidden_sizefor the vision adapter) and runs the usual smoke/dtype/push steps. SFT, DPO, and KTO tests now includetrl-internal-testing/tiny-MuseGlimmerForConditionalGeneration, gated below transformers 5.15.0.SFT chunked CE and distillation chunked JSD / Liger compatibility checks now read logit scaling from
text_configviaget_text_config()on VLMs and treat Muse Glimmer’soutput_multiplierlike Cohere-stylelogit_scale, so custom loss paths match the model’s real forward.Reviewed by Cursor Bugbot for commit 5094979. Bugbot is set up for automated code reviews on this repo. Configure here.