Make the installed TRL skill discoverable - #6745
Open
DaoyuanLi2816 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves TRL's packaged skill to the installed-library convention at
trl/.agents/skills/trl/SKILL.md, where generic dependency scanners can discover it without copying a stale snapshot.The skill is rewritten around the Python API, dataset contracts, custom reward functions, and the settings that materially affect correctness or throughput. This also removes the per-library
trl skillsinstaller and its implementation/tests; standard training CLI commands remain unchanged.The wheel and sdist both include the new skill path.
Fixes #6743
Before submitting
trl skills install#6743.Validation:
trl/.agents/skills/trl/SKILL.mdand no legacytrl/skills/filesmainAI writing disclosure
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
Note
Medium Risk
Removes a public CLI subcommand and Python APIs (
trl.skills), which is a breaking change for anyone usingtrl skills; training CLIs and core library behavior are unchanged.Overview
Packaged skill location and content — The wheel/sdist now ship
trl/.agents/skills/**/*(viaMANIFEST.in) instead oftrl/skills/**/*.md. A single skill lives attrl/.agents/skills/trl/SKILL.md(nametrl), focused on the Python API (trainers, dataset columns, GRPO rewards, throughput/correctness knobs) rather than the old CLI-centrictrl-trainingskill.Removed custom skills tooling — The entire
trl/skillspackage (skills.py,cli.py),SkillsCommand, andtrl skillslist/install/uninstall flow are deleted.get_commands()no longer registersskills; ruff’s per-file ignore fortrl/skills/cli.pyis dropped.Tests —
tests/test_skills.pyandtests/test_skills_cli.pyare removed.tests/test_packaged_skill.pynow asserts the installed-library skill path/metadata and that noskillsCLI command is registered.Reviewed by Cursor Bugbot for commit 211bb1f. Bugbot is set up for automated code reviews on this repo. Configure here.