Skip to content

Pass the pytest report log flag from the workflow instead of the Makefile - #6750

Open
albertvillanova wants to merge 3 commits into
mainfrom
ci-pytest-args-passthrough
Open

Pass the pytest report log flag from the workflow instead of the Makefile#6750
albertvillanova wants to merge 3 commits into
mainfrom
ci-pytest-args-passthrough

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Aug 14, 2026

Copy link
Copy Markdown
Member

Stacked on top of #6749.

This PR moves the pytest report log flag from the slow_tests Make target to the slow tests workflow.

Motivation

The report log is only needed by CI, where scripts/log_reports.py consumes it to build the job summary and the Slack report. Having the Make target check whether it runs in CI makes it aware of a concern that belongs to the workflow. Passing the flag from the caller keeps the target to a single job, running the slow tests.

Solution

The slow_tests target now forwards a PYTEST_ARGS variable to pytest, which is empty unless the caller sets it, and the workflow sets it to the report log flag. Running make slow_tests locally therefore no longer depends on pytest-reportlog being installed, and no longer needs any environment variable to behave as expected.

Changes

  • Forward a PYTEST_ARGS variable to pytest in the slow_tests Make target, instead of adding the report log flag when GITHUB_ACTIONS is set
  • Pass the report log flag from both slow tests jobs

Note

Low Risk
Makefile and workflow-only change; test behavior is unchanged except where CI explicitly passes the report log flag.

Overview
Moves pytest report logging out of the slow_tests Make target and into the slow-tests GitHub Actions workflow.

The slow_tests target now appends optional $(PYTEST_ARGS) to pytest instead of enabling --report-log when GITHUB_ACTIONS is set. Both single- and multi-GPU slow test jobs invoke make slow_tests PYTEST_ARGS="--report-log=slow_tests.log" so scripts/log_reports.py still gets the same log file for summaries and Slack.

Local make slow_tests no longer needs pytest-reportlog or CI env vars unless you pass your own PYTEST_ARGS.

Reviewed by Cursor Bugbot for commit 35a88eb. Bugbot is set up for automated code reviews on this repo. Configure here.

@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
albertvillanova force-pushed the ci-pytest-args-passthrough branch from d3e165f to ff65f9f Compare August 17, 2026 05:44
Base automatically changed from ci-drop-is-github-ci to main August 17, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant