Pass the pytest report log flag from the workflow instead of the Makefile - #6750
Open
albertvillanova wants to merge 3 commits into
Open
Pass the pytest report log flag from the workflow instead of the Makefile#6750albertvillanova wants to merge 3 commits into
albertvillanova wants to merge 3 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
force-pushed
the
ci-drop-is-github-ci
branch
from
August 17, 2026 05:44
02409f9 to
bfd400f
Compare
albertvillanova
force-pushed
the
ci-pytest-args-passthrough
branch
from
August 17, 2026 05:44
d3e165f to
ff65f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #6749.
This PR moves the pytest report log flag from the
slow_testsMake target to the slow tests workflow.Motivation
The report log is only needed by CI, where
scripts/log_reports.pyconsumes it to build the job summary and the Slack report. Having the Make target check whether it runs in CI makes it aware of a concern that belongs to the workflow. Passing the flag from the caller keeps the target to a single job, running the slow tests.Solution
The
slow_teststarget now forwards aPYTEST_ARGSvariable to pytest, which is empty unless the caller sets it, and the workflow sets it to the report log flag. Runningmake slow_testslocally therefore no longer depends onpytest-reportlogbeing installed, and no longer needs any environment variable to behave as expected.Changes
PYTEST_ARGSvariable to pytest in theslow_testsMake target, instead of adding the report log flag whenGITHUB_ACTIONSis setNote
Low Risk
Makefile and workflow-only change; test behavior is unchanged except where CI explicitly passes the report log flag.
Overview
Moves pytest report logging out of the
slow_testsMake target and into the slow-tests GitHub Actions workflow.The
slow_teststarget now appends optional$(PYTEST_ARGS)to pytest instead of enabling--report-logwhenGITHUB_ACTIONSis set. Both single- and multi-GPU slow test jobs invokemake slow_tests PYTEST_ARGS="--report-log=slow_tests.log"soscripts/log_reports.pystill gets the same log file for summaries and Slack.Local
make slow_testsno longer needspytest-reportlogor CI env vars unless you pass your ownPYTEST_ARGS.Reviewed by Cursor Bugbot for commit 35a88eb. Bugbot is set up for automated code reviews on this repo. Configure here.