Skip to content

Declare the test report dependencies in the test extra - #6756

Open
albertvillanova wants to merge 1 commit into
ci-slow-tests-slack-statusfrom
ci-test-deps-in-extras
Open

Declare the test report dependencies in the test extra#6756
albertvillanova wants to merge 1 commit into
ci-slow-tests-slack-statusfrom
ci-test-deps-in-extras

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Aug 14, 2026

Copy link
Copy Markdown
Member

Stacked on top of #6754.

This PR declares pytest-reportlog and tabulate in the test extra, instead of installing them from the slow tests workflow.

Motivation

Both jobs of the slow tests workflow install these two dependencies with their own uv pip install commands, while every other test dependency is declared in the test extra. As a consequence, they are missing from a local .[dev] install, so running make slow_tests with the report log flag locally fails on an unrecognized option, and the workflow has to know which dependencies the report needs.

Changes

  • Declare pytest-reportlog and tabulate in the test and dev extras
  • Stop installing them from the slow tests jobs

Note

Low Risk
Dependency and CI wiring only; no runtime library or test logic changes.

Overview
Moves pytest-reportlog and tabulate from ad-hoc installs in the slow-tests GitHub workflow into the test optional dependency (and mirrors them in dev), so they ship with .[dev] like the rest of the test stack.

Both slow-test jobs now rely on uv pip install ".[dev]" only—workflow steps that separately installed those packages before tests and before scripts/log_reports.py are removed. Local make slow_tests with report logging should match CI without extra manual installs.

Reviewed by Cursor Bugbot for commit 313d653. Bugbot is set up for automated code reviews on this repo. Configure here.

@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova

Copy link
Copy Markdown
Member Author

The Secret Leaks failure on this PR (run 31793772381) is unrelated to these changes.

Because the push created a branch, the action had no base commit and scanned the full history, where it re-verified the public hub-ci dummy token that lives in tests/testing_constants.py at 6e80e09. huggingface.co did not answer that verification within the usual time (2000 ms here, against 66 to 102 ms on the runs either side), so the detector reported it as unknown instead of a filtered 401, and the job exited 183. No credential needs rotating.

Re-running the job passes. Fix in #6759.

@qgallouedec
qgallouedec force-pushed the ci-test-deps-in-extras branch from 8ed1099 to 3356bb7 Compare August 14, 2026 18:41

@qgallouedec qgallouedec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants