Require liger-kernel 0.8.2 and drop the SAPO warning filter - #6768
Draft
albertvillanova wants to merge 2 commits into
Draft
Require liger-kernel 0.8.2 and drop the SAPO warning filter#6768albertvillanova wants to merge 2 commits into
albertvillanova wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR raises the liger-kernel floor to 0.8.2 in the
ligeranddevextras, replacing the!=0.8.1exclusion, and removes the SAPO warning filter that the bump makes obsolete.Fix #6767.
Fix #6435.
Warning
Draft: liger-kernel 0.8.2 is not released yet, so installation and CI will fail until it ships. Ready to merge as soon as it does.
Motivation
liger-kernel 0.8.1 crashes on pre-Ampere GPUs (CUDA compute capability < 8.0) in the fused linear cross-entropy backward pass, so it is currently excluded with
!=0.8.1(#6516, #6518). The upstream guard (linkedin/Liger-Kernel#1316) merged about 24 hours after 0.8.1 was tagged, so it ships in 0.8.2.The SAPO
IndexPutBackward0warning filter is coupled to the same bump: its upstream fix (linkedin/Liger-Kernel#1274) is in 0.8.1, which we exclude, so 0.8.2 is the first non-excluded release that contains it.Solution
Move the floor to
>=0.8.2rather than merely dropping the exclusion. A bare>=0.8.0would permanently re-permit the broken release, and it would not guarantee the SAPO fix either.Changes
liger-kernel>=0.8.2in theligerextra and in thedevextraIndexPutBackward0entry from the pytestfilterwarningslist, along with its comment block