Ensure device agnostic for examples/docs/templates - #6770
Open
kaixuanliu wants to merge 4 commits into
Open
Conversation
Signed-off-by: kaixuanliu <kaixuan.liu@intel.com>
Signed-off-by: kaixuanliu <kaixuan.liu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qgallouedec @albertvillanova @kashif pls help review, thx!
Note
Low Risk
Documentation, templates, and example-only code paths; the online DPO change is a like-for-like swap to an existing multi-device cache helper with no auth or data-handling impact.
Overview
Makes TRL docs, model cards, and vLLM examples work across accelerators instead of assuming CUDA.
Inference examples now pick the active device with
torch.accelerator.current_accelerator()(with CPU fallback in the use-model doc) and usedevice_map="auto"in generated model-card pipeline snippets instead ofdevice="cuda". Tests assert the updated card text.Training/runtime: Online DPO vLLM colocate wake-up calls the shared
empty_cache()helper instead oftorch.cuda.empty_cache(). TheVLLMClientdocstring and__main__block drop the cuda/xpu branch in favor oftorch.accelerator.current_accelerator()anddevice_mapfor loading weights.Reviewed by Cursor Bugbot for commit 89189cf. Bugbot is set up for automated code reviews on this repo. Configure here.