Fix bug in password entry and #489 (HMI Firmware threshold)#493
Fix bug in password entry and #489 (HMI Firmware threshold)#493hultenvp merged 9 commits intohultenvp:masterfrom
Conversation
|
Can confirm this has fixed both the missing inverter mode options & incorrect charge times displaying for me. |
…lp with multipl inverter support
|
in this bug: #492 there was a request to share logs, I shared logs there, did they contain the information needed? I would like to ask how to proceed ? Is there an update (3.14?) or do i need to do something within the H.A. environment to get the inverter control back online? |
|
Thanks for your log. I submitted a PR that fixes a number of bugs. Last thing I saw it was being reviewed. If and when it gets accepted there should be a new release. Not 100% sure it will fix your issue but if not please do the same again.
A shorter log excerpt is fine
…On 17 Aug 2025 at 06:54 +0100, TCW82 ***@***.***>, wrote:
TCW82 left a comment (hultenvp/solis-sensor#493)
in this bug: #492 there was a request to share logs, I shared logs there, did they contain the information needed? I would like to ask how to proceed ? Is there an update (3.14?) or do i need to do something within the H.A. environment to get the inverter control back online?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Ah, it looks like you already have the key fixes in this. Would you be open to me targeting my PR against your branch rather than the primary repo (Assuming you agree with my changes) #494 |
|
Sure
…On 17 Aug 2025 at 15:21 +0100, Carl Saggs ***@***.***>, wrote:
thybag left a comment (hultenvp/solis-sensor#493)
Ah, it looks like you already have the key fixes in this. Would you be open to me targeting my PR against your branch rather than the primary repo (Assuming you agree with my changes) #494
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
| @property | ||
| def unique_id(self) -> str: | ||
| return f"{self._platform_name}_{self._key}" | ||
| return f"{self._platform_name}_{self._inverter_sn}_{self._key}" |
There was a problem hiding this comment.
Why is this needed? Was key not unique enough?
|
|
||
| if user_input is not None: | ||
| self._data = user_input | ||
| self._data = dict(user_input) |
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
| RETRIES = 100 | ||
| # RETRIES = 100 |
There was a problem hiding this comment.
Can be completely removed instead of commenting out
| if inverter_serial not in self._hmi_fb00: | ||
| hmi_flag = self._data[HMI_VERSION_ALL] | ||
| self._hmi_fb00[inverter_serial] = int(hmi_flag, 16) >= int("4200", 16) | ||
| self._hmi_fb00[inverter_serial] = int(hmi_flag, 16) >= int("4b00", 16) |
There was a problem hiding this comment.
I do not have enough knowledge about the control API to assess this change.
@jmason?
EDIT: Looking at the readme the firmware threshold seems indeed to be 4B00h
There was a problem hiding this comment.
that came from this change -- #481 (comment) -- I was going by the comments noting that it seemed to improve issues there but sounds like it wasn't a good plan 😬
config_flow.pywhich was preventing the portal password being saved properly and hence disabling all control functions. This probably only affected new installations.v3.13where the wrong comparison was made for HMI firmware levels. This fixes Wrong inverter controls after latest update. #489 and may also fix Charge times and currents not updating / showing wrong values #487 and Inverter control not available in 3.13 #492.ALL_CONTROLS[False]["636"]whereintwhen they should bestr(as forALL_CONTROLS[False]["636"]). This resulted in the Energy Storage Switch always beingUnknownfor pre-FB00 HMI versions (Energy Storage Control Switch Status #443)