Skip to content

Fix bug in password entry and #489 (HMI Firmware threshold)#493

Merged
hultenvp merged 9 commits intohultenvp:masterfrom
fboundy:master
Aug 22, 2025
Merged

Fix bug in password entry and #489 (HMI Firmware threshold)#493
hultenvp merged 9 commits intohultenvp:masterfrom
fboundy:master

Conversation

@fboundy
Copy link
Copy Markdown
Contributor

@fboundy fboundy commented Aug 13, 2025

@fboundy fboundy changed the title Fix bug in password entry Fix bug in password entry and #489 (HMI Firmware threshold) Aug 13, 2025
@thybag
Copy link
Copy Markdown

thybag commented Aug 13, 2025

Can confirm this has fixed both the missing inverter mode options & incorrect charge times displaying for me.

@TCW82
Copy link
Copy Markdown

TCW82 commented Aug 17, 2025

in this bug: #492 there was a request to share logs, I shared logs there, did they contain the information needed? I would like to ask how to proceed ? Is there an update (3.14?) or do i need to do something within the H.A. environment to get the inverter control back online?

@fboundy
Copy link
Copy Markdown
Contributor Author

fboundy commented Aug 17, 2025 via email

@thybag
Copy link
Copy Markdown

thybag commented Aug 17, 2025

Ah, it looks like you already have the key fixes in this. Would you be open to me targeting my PR against your branch rather than the primary repo (Assuming you agree with my changes) #494

@fboundy
Copy link
Copy Markdown
Contributor Author

fboundy commented Aug 17, 2025 via email

Copy link
Copy Markdown
Owner

@hultenvp hultenvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is extra work for you, but individual PR's for individual issues are much easier to review with more chance of us spotting potential mistakes.

I'll wait for @jmason on the 4200h to 4B00h change.

@property
def unique_id(self) -> str:
return f"{self._platform_name}_{self._key}"
return f"{self._platform_name}_{self._inverter_sn}_{self._key}"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Was key not unique enough?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah never mind, relates to #442


if user_input is not None:
self._data = user_input
self._data = dict(user_input)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh! Good find.


_LOGGER = logging.getLogger(__name__)
RETRIES = 100
# RETRIES = 100
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be completely removed instead of commenting out

if inverter_serial not in self._hmi_fb00:
hmi_flag = self._data[HMI_VERSION_ALL]
self._hmi_fb00[inverter_serial] = int(hmi_flag, 16) >= int("4200", 16)
self._hmi_fb00[inverter_serial] = int(hmi_flag, 16) >= int("4b00", 16)
Copy link
Copy Markdown
Owner

@hultenvp hultenvp Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have enough knowledge about the control API to assess this change.
@jmason?

EDIT: Looking at the readme the firmware threshold seems indeed to be 4B00h

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that came from this change -- #481 (comment) -- I was going by the comments noting that it seemed to improve issues there but sounds like it wasn't a good plan 😬

@hultenvp hultenvp merged commit f11ca82 into hultenvp:master Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong inverter controls after latest update. Charge times and currents not updating / showing wrong values

5 participants