Add post-1.0 compatibility follow-up#7
Merged
Conversation
Owner
Author
|
@codex reveiw |
|
To use Codex here, create an environment for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.0.0compatibility fixture and gate1.0.0 -> currentwith PocketIC.npm run test:pocketic:compatin both PR CI and tag release workflow before the final root wasm build so release upload/import checks use the intended artifact.rust-version = "1.95.0"and guard it againstrust-toolchain.tomldrift.Audit note
v1.0.0was moved once before crates.io publish to include the release guard fix that compares peeled tag commits for annotated tags.Testing
rg -n '0\\.2\\.2|1\\.0\\.0|node20|node24|rust-version|checkout@|setup-node@|action-gh-release@' .github Cargo.toml docs package.json scripts tests compat-fixturesrg -n 'sqlite-critical-check|test:pocketic:compat|cargo build --target wasm32-unknown-unknown|test:pocketic:perf|Check wasm imports|action-gh-release' .github/workflowsscripts/check-release-version.shscripts/check-release-package.shgit diff --checkcargo fmt --checkcargo fmt --check --manifest-path compat-fixtures/ic-sqlite-vfs-1-0-0/Cargo.tomlcargo test --test public_apicargo test --testscargo build --target wasm32-unknown-unknowncargo build --target wasm32-unknown-unknown --features canister-apinpm run test:pocketic:compatwasm-objdump -x target/wasm32-unknown-unknown/debug/ic_sqlite_vfs.wasm