Open
Conversation
This content naturally expires within a few minutes anyway, so should not be manually invalidated. This prevents a flood of invalidations when content is first created, which also tends to happen at the highest traffic time.
mattheu
reviewed
Aug 20, 2025
Member
mattheu
left a comment
mattheu
left a comment
There was a problem hiding this comment.
Generally I like the implementation and the logic is good. However I think it would be nice for the LIFETIME_SHORT/MEDIUM/LONG constants to be filterable. This would for some experimentation and everything else is very customisable.
Rework settings page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Longcache's fixed lifetime with a smarter cache lifetime system based on the age of content and frequency of updates.