Update cvat payout calculator for the new manifest#3981
Open
portuu3 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
dnechay
reviewed
Jul 23, 2026
dnechay
left a comment
dnechay
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm overall, some cleanup comments
|
|
||
| for (const jobFinalResult of matchedJobResults) { | ||
| // TODO: enable annotation quality validation when ready | ||
| if ( |
Collaborator
There was a problem hiding this comment.
Already filtered above, so probably we can remove this check on jobFilanResult
Comment on lines
+63
to
69
| afterEach(() => { | ||
| jest.resetAllMocks(); | ||
| mockedEscrowClient.build.mockResolvedValue({ | ||
| getIntermediateResultsUrl: mockedGetIntermediateResultsUrl, | ||
| getReservedFunds: mockedGetReservedFunds, | ||
| } as unknown as EscrowClient); | ||
| }); |
Collaborator
There was a problem hiding this comment.
No need in this block
Suggested change
| afterEach(() => { | |
| jest.resetAllMocks(); | |
| mockedEscrowClient.build.mockResolvedValue({ | |
| getIntermediateResultsUrl: mockedGetIntermediateResultsUrl, | |
| getReservedFunds: mockedGetReservedFunds, | |
| } as unknown as EscrowClient); | |
| }); |
| const tokenDecimals = BigInt(6); | ||
| const jobCount = jobsPerAnnotator * annotators.length; | ||
| const payoutPerJob = BigInt(faker.number.int({ min: 1000, max: 100000 })); | ||
| const reservedFunds = payoutPerJob * BigInt(jobCount); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const reservedFunds = payoutPerJob * BigInt(jobCount); | |
| mockedGetReservedFunds.mockResolvedValueOnce(payoutPerJob * BigInt(jobCount)); |
| const mockedGetReservedFunds = jest | ||
| .fn() | ||
| .mockImplementation(async () => | ||
| BigInt(faker.number.int({ min: 1000, max: 100000 })), |
Collaborator
There was a problem hiding this comment.
Let's not mock default with some random number, because it can confuse in case of incorrect/failing test suite, it's better to mimic real behavior (i.e. funds not reserved) which returns 0n
Suggested change
| BigInt(faker.number.int({ min: 1000, max: 100000 })), | |
| 0n, |
Comment on lines
+142
to
149
| mockedGetReservedFunds.mockResolvedValueOnce(reservedFunds); | ||
| const manifest = generateCvatManifest(); | ||
| const payouts = await calculator.calculate({ | ||
| chainId, | ||
| escrowAddress, | ||
| manifest, | ||
| manifest: manifest, | ||
| finalResultsUrl: faker.internet.url(), | ||
| }); |
Collaborator
There was a problem hiding this comment.
Suggested change
| mockedGetReservedFunds.mockResolvedValueOnce(reservedFunds); | |
| const manifest = generateCvatManifest(); | |
| const payouts = await calculator.calculate({ | |
| chainId, | |
| escrowAddress, | |
| manifest, | |
| manifest: manifest, | |
| finalResultsUrl: faker.internet.url(), | |
| }); | |
| const payouts = await calculator.calculate({ | |
| chainId, | |
| escrowAddress, | |
| manifest: generateCvatManifest(), | |
| finalResultsUrl: faker.internet.url(), | |
| }); |
| results: [ | ||
| { | ||
| id: faker.number.int(), | ||
| job_id: faker.number.int(), |
Collaborator
There was a problem hiding this comment.
Even though we use faker there, there is a very little chance that faker.number.int() will generate final_result_id = result.id, so for the purpose of this test let's make sure somehow that those ids are 100% different
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
NA
Context behind the change
Update cvat payout calculator for the new manifest
How has this been tested?
Tested using unit tests
Pending to test with CVAT oracles on testnet when ready
Release plan
NA
Potential risks; What to monitor; Rollback plan
NA