Style/gofmt cleanup#120
Merged
Merged
Conversation
Whitespace-only: struct-field realignment and trailing-newline trim on the two files touched this session. No logic change.
Formatting only (alignment, line-grouping, blank lines) — no logic change; full suite green. Excludes sql_validate.go, handled separately.
The comment documented SQL's '' and backtick-doubling escapes literally; gofmt's TeX-style quote substitution would rewrite those pairs into curly quotes and corrupt the meaning. Reword to describe the escape without the trigger pairs, keeping the file gofmt-clean.
errcheck excludes conventional no-action calls (Close, fmt.Fprint*, os.Remove cleanup, deferred SDK stream Close) and skips test setup; issue caps lifted so repeats are not silently hidden.
Remove dead fields/const/func (unused) and apply staticcheck quickfixes (De Morgan, tagged switch, merged assignment, string conversion). No behavior change; full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.