Fix setup-github-app manifest creation and configure webhook secret#409
Open
carlosjdelgado wants to merge 1 commit into
Open
Fix setup-github-app manifest creation and configure webhook secret#409carlosjdelgado wants to merge 1 commit into
carlosjdelgado wants to merge 1 commit into
Conversation
carlosjdelgado
force-pushed
the
fix/setup-github-app
branch
from
8069d2e to
9e52209
Compare
GitHub rejects manifests with `secret` inside `hook_attributes` and renamed the user permission to `emails`. After the app is created, the script now PATCHes /app/hook/config with a JWT signed via stdlib crypto so the webhook secret in .env matches what GitHub stores.
carlosjdelgado
force-pushed
the
fix/setup-github-app
branch
from
9e52209 to
fe797fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub rejects manifests with
secretinsidehook_attributesand renamed the user permission toemails. After the app is created, the script now PATCHes /app/hook/config with a JWT signed via stdlib crypto so the webhook secret in .env matches what GitHub stores.