[Subview] unify lowering on parent-shape + valid dims (PR344 follow-up)#351
Closed
TaoTao-real wants to merge 2 commits intohw-native-sys:mainfrom
Closed
[Subview] unify lowering on parent-shape + valid dims (PR344 follow-up)#351TaoTao-real wants to merge 2 commits intohw-native-sys:mainfrom
TaoTao-real wants to merge 2 commits intohw-native-sys:mainfrom
Conversation
Contributor
Author
|
Superseded by updating PR #344 directly. Closing this duplicate follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up on top of #344 and keeps the implementation on the same line.
It unifies subview lowering semantics and removes compact/non-compact bifurcation.
What changed
subviewresult tile shape as parent shape.valid_row/valid_col(default fromsizes, explicit valid clamped by size).pto.view_semantics = "subview".Files
lib/PTO/Transforms/PTOViewToMemref.cpplib/PTO/Transforms/PTOToEmitC.cpplib/PTO/IR/PTO.cppinclude/PTO/IR/PTOOps.tddocs/PTO_IR_manual.mdWhy
This aligns the implementation to the requested model:
Validation
Local
runop.sh -t SubView: pass (with expected XFAIL)runop.sh -t Sync: pass (with expected SKIP/XFAIL)Board (Ascend910, device 2, CI-like params)
test/npu_validation/scripts/run_remote_npu_validation.shSTAGE=run RUN_MODE=npu SOC_VERSION=Ascend910 DEVICE_ID=2PTO_ISA_COMMIT=893e4b00a826231e776539512b5b17f82fc11838SKIP_CASES=mix_kernel,vadd_validshape,vadd_validshape_dynamic,print,storefp,partition5d_a5,partition5d_dynamic_a5,mrgsort_a5,tmatmulk_autosync_a5OK=166 FAIL=0 SKIP=9