fix(emitc): remove alloc_tile(addr) dynamic rewrap double TASSIGN#406
Open
TaoTao-real wants to merge 1 commit intohw-native-sys:mainfrom
Open
fix(emitc): remove alloc_tile(addr) dynamic rewrap double TASSIGN#406TaoTao-real wants to merge 1 commit intohw-native-sys:mainfrom
TaoTao-real wants to merge 1 commit intohw-native-sys:mainfrom
Conversation
Codex Review该评论由 review 机器人自动更新。
Summary未检查到 PR #406 存在问题 FindingsNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alloc_tile addr=...with dynamic valid shapepto.pointer_castinstead ofpointer_cast + bind_tileTASSIGN/.data()bridge reappearingRoot cause
pointer_cast + bind_tile.TASSIGN(new, old.data()).Fix
pto.pointer_cast(with__pto.force_dynamic_valid_shapepreserved).Tests
build/tools/ptoas/ptoas --pto-level=level3 test/basic/alloc_tile_addr_dynamic_no_rebind.pto | FileCheck test/basic/alloc_tile_addr_dynamic_no_rebind.ptobuild/tools/ptoas/ptoas test/basic/tprint_alloc_tile_no_rebind.pto | FileCheck test/basic/tprint_alloc_tile_no_rebind.pto9f72fef(build/kernel.pto): generated C++ no longer contains.data()/reinterpret_cast<uint64_t>(tile.data())bridge and each logical tile has a singleTASSIGN.