You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
allow selected PTO ops to accept i64 or index operands for pointer/view-related indices
allow selected tile ops to accept u32-compatible or index operands for valid-shape and tile element indexing
preserve existing textual syntax by default and bridge compatible integer operands back to index where lowering still requires it
Details
add IndexOrI64 and IndexOrU32 operand constraints in ODS
add custom asm parsing/printing for ops whose old syntax omitted operand types so old IR stays valid while non-index operands can still be printed and parsed
relax verifiers for textract/tinsert and add uniform compatible-type checks for grouped operands
update PTOViewToMemref lowering to cast compatible integer operands back to index before feeding memref.dim, bind_tile, and pointer_cast
Validation
built ptoas and ptobc successfully in WSL against the updated workspace sources
onst {
| ^~~~
/tmp/ptoas-board-monitor/runs/20260401_170403_manual_pr411/repo/lib/PTO/Transforms/PTOToEmitC.cpp: At global scope:
/tmp/ptoas-board-monitor/runs/20260401_170403_manual_pr411/repo/lib/PTO/Transforms/PTOToEmitC.cpp:5933:20: warning: ‘std::string maskPatternTok(mlir::pto::MaskPatternAttr)’ defined but not used [-Wunused-function]
5933 | static std::string maskPatternTok(mlir::pto::MaskPatternAttr a) {
| ^~~~~~~~~~~~~~
/tmp/ptoas-board-monitor/runs/20260401_170403_manual_pr411/repo/lib/PTO/Transforms/PTOToEmitC.cpp:3815:20: warning: ‘std::string getPipeName(mlir::pto::PIPE)’ defined but not used [-Wunused-function]
3815 | static std::string getPipeName(pto::PIPE pipe) {
| ^~~~~~~~~~~
/tmp/ptoas-board-monitor/runs/20260401_170403_manual_pr411/repo/lib/PTO/Transforms/PTOToEmitC.cpp:2505:13: warning: ‘Role inferSubviewRole(mlir::memref::SubViewOp)’ defined but not used [-Wunused-function]
2505 | static Role inferSubviewRole(memref::SubViewOp sv) {
| ^~~~~~~~~~~~~~~~
/tmp/ptoas-board-monitor/runs/20260401_170403_manual_pr411/repo/lib/PTO/Transforms/PTOToEmitC.cpp:2365:13: warning: ‘void inferTileMNK(mlir::func::FuncOp, int&, int&, int&)’ defined but not used [-Wunused-function]
2365 | static void inferTileMNK(func::FuncOp f, int &M, int &N, int &K) {
| ^~~~~~~~~~~~
/tmp/ptoas-board-monitor/runs/20260401_170403_manual_pr411/repo/lib/PTO/Transforms/PTOToEmitC.cpp:2352:19: warning: ‘KernelKind inferKernelKind(mlir::func::FuncOp)’ defined but not used [-Wunused-function]
2352 | static KernelKind inferKernelKind(func::FuncOp f) {
| ^~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
===== END STAGE build-ptoas rc=1 @ 2026-04-01 17:04:50 =====
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i64orindexoperands for pointer/view-related indicesu32-compatible orindexoperands for valid-shape and tile element indexingindexwhere lowering still requires itDetails
IndexOrI64andIndexOrU32operand constraints in ODSindexoperands can still be printed and parsedtextract/tinsertand add uniform compatible-type checks for grouped operandsPTOViewToMemreflowering to cast compatible integer operands back toindexbefore feedingmemref.dim,bind_tile, andpointer_castValidation
ptoasandptobcsuccessfully in WSL against the updated workspace sources