CI: upgrade ptoas to v0.22 and update repo org references by zhangqi-chen · Pull Request #72 · hw-native-sys/pypto-lib

zhangqi-chen · 2026-04-07T07:18:02Z

Summary

Bump PTOAS_VERSION from v0.17 to v0.22 in all CI jobs (a2a3sim, a5sim, a2a3)
Migrate zhangstevenunity/PTOAS → hw-native-sys/PTOAS across CI, skills, and docs
Migrate ChaoWao/simpler → hw-native-sys/simpler across skills and docs

Related Issues

N/A

coderabbitai · 2026-04-07T07:18:21Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3e911327-477d-42e3-83aa-3d04434615f9

📥 Commits

Reviewing files that changed from the base of the PR and between 9f206a3 and c58df4f.

📒 Files selected for processing (4)

.claude/CLAUDE.md
.claude/skills/create-issue/SKILL.md
.claude/skills/setup_env/SKILL.md
.github/workflows/ci.yml

✅ Files skipped from review due to trivial changes (2)

.claude/CLAUDE.md
.claude/skills/setup_env/SKILL.md

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci.yml

📝 Walkthrough

Walkthrough

Updated pinned PTOAS release version from v0.17 to v0.22, switched PTOAS GitHub release host from zhangstevenunity/PTOAS to hw-native-sys/PTOAS, and updated simpler repository references from ChaoWao/simpler to hw-native-sys/simpler across CI and Claude skill docs.

Changes

Cohort / File(s)	Summary
CI workflow `.github/workflows/ci.yml`	Bumped `PTOAS_VERSION` to `v0.22` and updated PTOAS release download URLs to `github.com/hw-native-sys/PTOAS` for x86_64 and aarch64 in all three jobs (`a2a3sim`, `a5sim`, `a2a3`).
Claude setup & skills docs `.claude/skills/setup_env/SKILL.md`, `.claude/skills/create-issue/SKILL.md`, `.claude/CLAUDE.md`	Replaced `zhangstevenunity/PTOAS` with `hw-native-sys/PTOAS` and updated `simpler` repo references from `ChaoWao/simpler` to `hw-native-sys/simpler` in external-dependency entries and embedded prompts/instructions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Add a2a3 CI job for on-device hello_world test #15: Updates CI PTOAS installation/version references (strong overlap with CI changes).
CI: add multi-platform CLI and a5sim job, upgrade ptoas to v0.17 #49: Previously adjusted PTOAS version and setup docs (similar scope to this PR).
Pin PTOAS version to v0.6 with checksum verification #8: Modifies PTOAS download/version references in docs and install flow (closely related).

Poem

🐰 I hopped through files with a nimble cheer,
Bumped PTOAS up and pointed repos clear,
Docs and CI now follow the same trail,
A tidy hop forward—short, swift, and hale! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: upgrading ptoas to v0.22 and updating repository organization references.
Description check	✅ Passed	The description clearly relates to the changeset, providing specific details about version bumps and repository migrations across all affected files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request updates the PTOAS_VERSION from v0.17 to v0.22 in the environment setup documentation. A review comment points out that while the PR description mentions updating all CI jobs, the actual changes to the CI configuration files (such as .github/workflows/ci.yml) are missing from the pull request, which is necessary to maintain consistency between the local environment and the CI pipeline.

.claude/skills/setup_env/SKILL.md

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

.claude/skills/setup_env/SKILL.md (1)
49-57: ⚠️ Potential issue | 🟠 Major

Update chmod command to reference only the canonical PTOAS binary path.

Line 56 chmods both $WORKSPACE_DIR/ptoas-bin/ptoas and $WORKSPACE_DIR/ptoas-bin/bin/ptoas. The canonical executable is $PTOAS_ROOT/ptoas only; bin/ptoas is a legacy artifact from earlier tarball layouts and should not be documented as a supported path.
Proposed fix
-chmod +x "$WORKSPACE_DIR/ptoas-bin/ptoas" "$WORKSPACE_DIR/ptoas-bin/bin/ptoas"
+chmod +x "$WORKSPACE_DIR/ptoas-bin/ptoas"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude/skills/setup_env/SKILL.md around lines 49 - 57, The chmod line is
updating two paths including a legacy location; change it to only make the
canonical PTOAS binary executable by replacing the chmod target list with the
canonical path referenced by PTOAS_ROOT (i.e., use "$PTOAS_ROOT/ptoas" or
"$WORKSPACE_DIR/ptoas-bin/ptoas" via PTOAS_ROOT) and remove any reference to
"$WORKSPACE_DIR/ptoas-bin/bin/ptoas" so only PTOAS_ROOT/ptoas is documented and
made executable; update the chmod invocation that currently mentions both paths
accordingly.
.github/workflows/ci.yml (1)
59-67: ⚠️ Potential issue | 🟡 Minor

Remove redundant bin/ptoas chmod operations from all three Install ptoas blocks.

The tarball includes both ./ptoas and ./bin/ptoas, but bin/ptoas is a legacy artifact. Only ./ptoas should be referenced per the canonical binary location. Remove the redundant chmod from lines 66, 127, and 190.
Proposed workflow fix
          chmod +x $GITHUB_WORKSPACE/ptoas-bin/ptoas
-         chmod +x $GITHUB_WORKSPACE/ptoas-bin/bin/ptoas
Apply the same removal in all three Install ptoas blocks.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 59 - 67, The workflow contains
redundant chmod calls for the legacy binary path bin/ptoas; in each "Install
ptoas" block (the steps that set PTOAS_VERSION and extract ptoas), remove the
chmod +x $GITHUB_WORKSPACE/ptoas-bin/bin/ptoas lines and only keep chmod +x
$GITHUB_WORKSPACE/ptoas-bin/ptoas so the canonical ./ptoas binary is used;
update all three occurrences (the blocks around the current chmod lines) to drop
the bin/ptoas chmod.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.claude/skills/setup_env/SKILL.md:
- Around line 49-57: The chmod line is updating two paths including a legacy
location; change it to only make the canonical PTOAS binary executable by
replacing the chmod target list with the canonical path referenced by PTOAS_ROOT
(i.e., use "$PTOAS_ROOT/ptoas" or "$WORKSPACE_DIR/ptoas-bin/ptoas" via
PTOAS_ROOT) and remove any reference to "$WORKSPACE_DIR/ptoas-bin/bin/ptoas" so
only PTOAS_ROOT/ptoas is documented and made executable; update the chmod
invocation that currently mentions both paths accordingly.

In @.github/workflows/ci.yml:
- Around line 59-67: The workflow contains redundant chmod calls for the legacy
binary path bin/ptoas; in each "Install ptoas" block (the steps that set
PTOAS_VERSION and extract ptoas), remove the chmod +x
$GITHUB_WORKSPACE/ptoas-bin/bin/ptoas lines and only keep chmod +x
$GITHUB_WORKSPACE/ptoas-bin/ptoas so the canonical ./ptoas binary is used;
update all three occurrences (the blocks around the current chmod lines) to drop
the bin/ptoas chmod.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c696b70-7c69-4fbf-a11f-5dfc4b0fca1b

📥 Commits

Reviewing files that changed from the base of the PR and between 9a4a25f and 9f206a3.

📒 Files selected for processing (2)

.claude/skills/setup_env/SKILL.md
.github/workflows/ci.yml

- Bump PTOAS_VERSION from v0.17 to v0.22 in all CI jobs - Migrate zhangstevenunity/PTOAS → hw-native-sys/PTOAS - Migrate ChaoWao/simpler → hw-native-sys/simpler - Update setup_env skill, create-issue skill, and CLAUDE.md

gemini-code-assist bot reviewed Apr 7, 2026

View reviewed changes

.claude/skills/setup_env/SKILL.md Show resolved Hide resolved

coderabbitai bot reviewed Apr 7, 2026

View reviewed changes

CI: upgrade ptoas to v0.22 and update repo org references

c58df4f

- Bump PTOAS_VERSION from v0.17 to v0.22 in all CI jobs - Migrate zhangstevenunity/PTOAS → hw-native-sys/PTOAS - Migrate ChaoWao/simpler → hw-native-sys/simpler - Update setup_env skill, create-issue skill, and CLAUDE.md

zhangqi-chen force-pushed the ci-upgrade-ptoas-v0.22 branch from 9f206a3 to c58df4f Compare April 7, 2026 07:28

zhangqi-chen changed the title ~~CI: upgrade ptoas from v0.17 to v0.22~~ CI: upgrade ptoas to v0.22 and update repo org references Apr 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: upgrade ptoas to v0.22 and update repo org references#72

CI: upgrade ptoas to v0.22 and update repo org references#72
zhangqi-chen wants to merge 1 commit intohw-native-sys:mainfrom
zhangqi-chen:ci-upgrade-ptoas-v0.22

zhangqi-chen commented Apr 7, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 7, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

zhangqi-chen commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issues

Uh oh!

coderabbitai bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zhangqi-chen commented Apr 7, 2026 •

edited

Loading

coderabbitai bot commented Apr 7, 2026 •

edited

Loading