Skip to content

ci: Add dependabot for requirements#410

Open
georgebisbas wants to merge 1 commit intohw-native-sys:mainfrom
georgebisbas:dependabot
Open

ci: Add dependabot for requirements#410
georgebisbas wants to merge 1 commit intohw-native-sys:mainfrom
georgebisbas:dependabot

Conversation

@georgebisbas
Copy link
Copy Markdown

Add dependabot for handling future python releases on dependencies

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Dependabot configuration for automated dependency updates and adds a new CI requirements file. The review feedback correctly identifies that the Dependabot pip ecosystem configuration points to the root directory, which will miss the new requirements/ci.txt file located in the requirements subdirectory; a change to the directory path is recommended to ensure proper tracking.

version: 2
updates:
- package-ecosystem: "pip"
directory: "/"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pip package-ecosystem is configured to look in the root directory (/), but the new requirements file requirements/ci.txt is located in the requirements subdirectory. To ensure Dependabot can find and update the dependencies in requirements/ci.txt, the directory should be set to /requirements.

Note that this change will cause Dependabot to stop scanning for dependencies in pyproject.toml at the root level. If you intend to update dependencies in both files, you will need to create a second, separate entry for the pip package-ecosystem with directory: "/".

    directory: "/requirements"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ci: Add dependabot for requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant