Skip to content

[WIP] Fix: two ring-buffer allocator defects in pto_ring_buffer.h #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenshengxin2026 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

[WIP] Fix: two ring-buffer allocator defects in pto_ring_buffer.h #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/a2a3/runtime/aicpu_build_graph/runtime/pto_ring_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ struct PTO2HeapRing {
if (space_at_end >= alloc_size) {
new_top = top + alloc_size;
result = (char *)base + top;
} else if (tail > alloc_size) {
} else if (tail >= alloc_size) {
// Wrap to beginning
new_top = alloc_size;
result = base;
Expand Down Expand Up @@ -545,7 +545,7 @@ struct PTO2DepListPool {
*/
PTO2DepListEntry *alloc() {
int32_t used = top - tail;
if (used >= capacity) {
if (used >= capacity - 1) {
LOG_ERROR("========================================");
LOG_ERROR("FATAL: Dependency Pool Overflow!");
LOG_ERROR("========================================");
Expand All @@ -563,7 +563,7 @@ struct PTO2DepListPool {
}
return nullptr;
}
int32_t idx = top % capacity;
int32_t idx = static_cast<int32_t>((static_cast<uint32_t>(top) - 1) % (capacity - 1)) + 1;
top++;
used++;
if (used > high_water) high_water = used;
Expand Down
6 changes: 3 additions & 3 deletions src/a2a3/runtime/tensormap_and_ringbuffer/runtime/pto_ring_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ class PTO2TaskAllocator {
if (space_at_end >= alloc_size) {
result = static_cast<char *>(heap_base_) + top;
heap_top_ = top + alloc_size;
} else if (tail > alloc_size) {
} else if (tail >= alloc_size) {
result = heap_base_;
heap_top_ = alloc_size;
} else {
Expand Down Expand Up @@ -426,7 +426,7 @@ struct PTO2DepListPool {
*/
PTO2DepListEntry *alloc() {
int32_t used = top - tail;
if (used >= capacity) {
if (used >= capacity - 1) {
LOG_ERROR("========================================");
LOG_ERROR("FATAL: Dependency Pool Overflow!");
LOG_ERROR("========================================");
Expand All @@ -444,7 +444,7 @@ struct PTO2DepListPool {
}
return nullptr;
}
int32_t idx = top % capacity;
int32_t idx = static_cast<int32_t>((static_cast<uint32_t>(top) - 1) % (capacity - 1)) + 1;
top++;
used++;
if (used > high_water) high_water = used;
Expand Down
6 changes: 3 additions & 3 deletions src/a5/runtime/tensormap_and_ringbuffer/runtime/pto_ring_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ class PTO2TaskAllocator {
if (space_at_end >= alloc_size) {
result = static_cast<char *>(heap_base_) + top;
heap_top_ = top + alloc_size;
} else if (tail > alloc_size) {
} else if (tail >= alloc_size) {
result = heap_base_;
heap_top_ = alloc_size;
} else {
Expand Down Expand Up @@ -426,7 +426,7 @@ struct PTO2DepListPool {
*/
PTO2DepListEntry *alloc() {
int32_t used = top - tail;
if (used >= capacity) {
if (used >= capacity - 1) {
LOG_ERROR("========================================");
LOG_ERROR("FATAL: Dependency Pool Overflow!");
LOG_ERROR("========================================");
Expand All @@ -444,7 +444,7 @@ struct PTO2DepListPool {
}
return nullptr;
}
int32_t idx = top % capacity;
int32_t idx = static_cast<int32_t>((static_cast<uint32_t>(top) - 1) % (capacity - 1)) + 1;
top++;
used++;
if (used > high_water) high_water = used;
Expand Down
Loading