perf: replace RSA 2048 with ECDSA P-256 for cert generation#17
Merged
Conversation
- Replace 'darwin' with 'macos' for user-facing clarity - Embed version tag in filename so multi-version downloads are unambiguous - Update README download table and install example to match new names https://claude.ai/code/session_01PPLEf2tHHFhw9rpW8dpdA3
ECDSA P-256 key generation is ~100x faster than RSA 2048 (~0.3ms vs ~80ms), eliminating the per-host latency spike on first connection. Security is equivalent for this use case. Also remove KeyUsageKeyEncipherment from both CA and leaf templates — that flag is RSA key-exchange specific and has no meaning for ECDSA. https://claude.ai/code/session_01PPLEf2tHHFhw9rpW8dpdA3
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsa.GenerateKey(rand.Reader, 2048)withecdsa.GenerateKey(elliptic.P256(), rand.Reader)for both CA and per-host leaf certificatesKeyUsageKeyEnciphermentfrom both templates — this flag is RSA key-exchange specific and is meaningless for ECDSAPerformance
Eliminates the latency spike on first connection to each new host. Security is equivalent.
Compatibility
ECDSA P-256 is supported by all tools httpmon targets: curl 7.x+, aws CLI, Python requests, Node.js 14+, Go stdlib.
Test plan
go build ./...passesgo test -race -count=1 -timeout 120s ./...passes (all 38 tests)https://claude.ai/code/session_01PPLEf2tHHFhw9rpW8dpdA3
Generated by Claude Code