Routing robustness, continued: constrain Unauthorized / KMS / mismatch (v0.6.8)#127
Merged
Conversation
Finishes the v0.6.7 routing-robustness pass by constraining the last three bare signatures from the v0.6.2 audit. detect_domain only; guarded by routing-corpus (every golden case still top-2) and negative-corpus. - Unauthorized (security): now requires "401 Unauthorized" or an access/request/ operation/credential/signature neighbour (was bare, matched any prose). - KMS (security): now requires the kms: action form or a crypto neighbour (key/encrypt/decrypt/SSE/cipher/CMK/GenerateDataKey) (was bare). - mismatch (data-consistency): now requires a data neighbour (etag/checksum/hash/ md5/content/object/data/digest/size/byte), so "version/schema mismatch" no longer misroutes (was bare). Three negative-corpus cases lock the guards; verified the real forms still fire and dependent golden cases (kms-denied-encrypt, multipart-etag-rechunk-mismatch) still route. Validation: all gates green; 219 pytest + 21 extension tests; 32/32 baselines PASS. Version 0.6.7 -> 0.6.8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QhkyBLeDtBTmvTdVBqgCAV
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the routing-robustness pass started in v0.6.7 by constraining the three remaining bare signatures the v0.6.2 audit flagged.
detect_domainonly, guarded by routing-corpus (every golden case still recalls its skill top-2) and negative-corpus.Constrained signals
Unauthorized(security):[/Unauthorized/i]matched any prose use ("unauthorized change to the wiki"). Now requires401 Unauthorizedor an access/request/operation/credential/signature neighbour.KMS(security):[/KMS/i]matched any mention. Now requires thekms:action form or a crypto neighbour (key/encrypt/decrypt/SSE/cipher/CMK/GenerateDataKey) — an unrelated "KMS team roadmap" no longer routes to security.mismatch(data-consistency):[/mismatch/i]matched "version mismatch" / "schema mismatch". Now requires a data neighbour (etag/checksum/hash/md5/content/object/data/digest/size/byte) — a "firmware version mismatch" no longer routes to data-consistency.Safety
401 Unauthorized,kms:GenerateDataKey,SSE-KMS … decrypt,ETag mismatch,checksum mismatch).kms-denied-encrypt,multipart-etag-rechunk-mismatch) still route top-2.Validation
All gates green; 219 pytest + 21 extension tests (incl. the 3 new negative-corpus cases + routing-corpus); 32/32 baselines 100% PASS. Version 0.6.7 → 0.6.8.
🤖 Generated with Claude Code
Generated by Claude Code