Add support for CMD/Meta key in place of CTRL#88
Open
bencoder wants to merge 1 commit into
Open
Conversation
Member
|
Hi! I don't have a mac to try it on right now, but I remember there being a reason that I did it this way when I started developing hydra on a mac. (Can't remember now though!) Does the alt key still work fine with this pull request? I want to make sure we try on major operating systems and browsers before merging this. |
Author
|
Hi! Yes the alt key still works for me. On Chrome and Firefox. Understand completely, I don't have a windows/linux machine right now so I can't test what effect it has there. Potential issues that I see
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really struggle to get used to using control key on Mac when almost everything else uses the command key in its place.
It makes it more comfortable for me to use, but there might be something I've missed that makes this not a good idea. Happy for feedback!