Remove bookmark_track from create, update README for fork workflows#36
Draft
MingweiSamuel wants to merge 3 commits intomainfrom
Draft
Remove bookmark_track from create, update README for fork workflows#36MingweiSamuel wants to merge 3 commits intomainfrom
MingweiSamuel wants to merge 3 commits intomainfrom
Conversation
MingweiSamuel
added a commit
that referenced
this pull request
May 4, 2026
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 4, 2026
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 4, 2026
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
97bd096 to
2fd0740
Compare
MingweiSamuel
force-pushed
the
install-aliases
branch
from
b63fe29 to
759e910
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36 Resolve merge conflicts by combining both tracked_bookmarks and push_remote parameters The conflict arose because two changes landed on the same code: 1. `ryokvxyk` (rebase destination) added a `tracked_bookmarks` parameter to `pr_dag::build()` and reformatted calls to multi-line. 2. `uspmwzsl` added a `push_remote` parameter to `pr_dag::build()`. Resolution: The `build()` function signature now accepts both parameters (`tracked_bookmarks` and `push_remote`), and all call sites pass both arguments. Tests use "origin" as the push_remote value. All 33 tests pass. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
2fd0740 to
e32086b
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36 Resolve merge conflicts by combining both tracked_bookmarks and push_remote parameters The conflict arose because two changes landed on the same code: 1. `ryokvxyk` (rebase destination) added a `tracked_bookmarks` parameter to `pr_dag::build()` and reformatted calls to multi-line. 2. `uspmwzsl` added a `push_remote` parameter to `pr_dag::build()`. Resolution: The `build()` function signature now accepts both parameters (`tracked_bookmarks` and `push_remote`), and all call sites pass both arguments. Tests use "origin" as the push_remote value. All 33 tests pass. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
e32086b to
b973890
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36 Resolve merge conflicts by combining both tracked_bookmarks and push_remote parameters The conflict arose because two changes landed on the same code: 1. `ryokvxyk` (rebase destination) added a `tracked_bookmarks` parameter to `pr_dag::build()` and reformatted calls to multi-line. 2. `uspmwzsl` added a `push_remote` parameter to `pr_dag::build()`. Resolution: The `build()` function signature now accepts both parameters (`tracked_bookmarks` and `push_remote`), and all call sites pass both arguments. Tests use "origin" as the push_remote value. All 33 tests pass. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
b973890 to
2f60cdb
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36 Resolve merge conflicts by combining both tracked_bookmarks and push_remote parameters The conflict arose because two changes landed on the same code: 1. `ryokvxyk` (rebase destination) added a `tracked_bookmarks` parameter to `pr_dag::build()` and reformatted calls to multi-line. 2. `uspmwzsl` added a `push_remote` parameter to `pr_dag::build()`. Resolution: The `build()` function signature now accepts both parameters (`tracked_bookmarks` and `push_remote`), and all call sites pass both arguments. Tests use "origin" as the push_remote value. All 33 tests pass. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
2f60cdb to
826417c
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36 Resolve merge conflicts by combining both tracked_bookmarks and push_remote parameters The conflict arose because two changes landed on the same code: 1. `ryokvxyk` (rebase destination) added a `tracked_bookmarks` parameter to `pr_dag::build()` and reformatted calls to multi-line. 2. `uspmwzsl` added a `push_remote` parameter to `pr_dag::build()`. Resolution: The `build()` function signature now accepts both parameters (`tracked_bookmarks` and `push_remote`), and all call sites pass both arguments. Tests use "origin" as the push_remote value. All 33 tests pass. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
MingweiSamuel
added a commit
that referenced
this pull request
May 5, 2026
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
826417c to
576130a
Compare
Added jj::push_remote() which reads `git.push` from jj config, falling back to "origin". This is threaded through: - build() for pr_needs_push comparison (compares against push remote) - execute_create() for bookmark_track Removes the TODO comment about hardcoded "origin". Users with fork workflows can now set `jj config set --repo git.push "fork"` and jj-pr will compare/push against that remote. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36 Resolve merge conflicts by combining both tracked_bookmarks and push_remote parameters The conflict arose because two changes landed on the same code: 1. `ryokvxyk` (rebase destination) added a `tracked_bookmarks` parameter to `pr_dag::build()` and reformatted calls to multi-line. 2. `uspmwzsl` added a `push_remote` parameter to `pr_dag::build()`. Resolution: The `build()` function signature now accepts both parameters (`tracked_bookmarks` and `push_remote`), and all call sites pass both arguments. Tests use "origin" as the push_remote value. All 33 tests pass. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
Fetch `headRepositoryOwner { login }` in the PR GraphQL query and store
it as `head_repo_owner: Option<String>` on GhPr. This enables future
filtering/disambiguation for fork-based workflows where multiple users
might have branches with the same name.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
PR: #36
Removed the bookmark_track call from execute_create — it's not needed for push (jj git push uses git.push config) and tracking is a user preference about fetch behavior, not create's responsibility. Updated README: removed "remote hardcoded to origin" limitation, added a "Fork Workflows" section explaining `jj config set --repo git.push`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #36
MingweiSamuel
force-pushed
the
handle-forks
branch
from
576130a to
35e6a03
Compare
MingweiSamuel
commented
May 5, 2026
Comment on lines
+150
to
+158
| If you push to a personal fork instead of the upstream repo, configure jj's push remote: | ||
|
|
||
| ```sh | ||
| jj config set --repo git.push "fork" | ||
| ``` | ||
|
|
||
| jj-pr reads this setting to determine which remote to compare bookmarks against for push detection. `gh pr create` | ||
| automatically handles cross-repo PRs when you push to a fork. | ||
|
|
Member
Author
There was a problem hiding this comment.
Needs to be updated? up to the user to set the remote tracking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the bookmark_track call from execute_create — it's not needed
for push (jj git push uses git.push config) and tracking is a user
preference about fetch behavior, not create's responsibility.
Updated README: removed "remote hardcoded to origin" limitation, added
a "Fork Workflows" section explaining
jj config set --repo git.push.Co-authored-by: Infinity 🤖 infinity@hydro.run