Skip to content

Add edge intersection test to Contains3D#1047

Open
DmytroMuravskyi wants to merge 2 commits into
hypar-io:masterfrom
DmytroMuravskyi:dmuravskyi/contains-3d
Open

Add edge intersection test to Contains3D#1047
DmytroMuravskyi wants to merge 2 commits into
hypar-io:masterfrom
DmytroMuravskyi:dmuravskyi/contains-3d

Conversation

@DmytroMuravskyi
Copy link
Copy Markdown
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Oct 30, 2023

BACKGROUND:

DESCRIPTION:

  • Covers function already had needed logic implemented. Since the only difference between them is how they treat containment, this logic is reused for Contains3D.
  • Implementation of Cover is moved into shared static Contains function.

TESTING:

  • Added Contains3d test to PolygonTests.

FUTURE WORK:

  • There are inconsistency between different Covers and Contains functions described in the issue. New issue will be created to address this.

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant