Skip to content

continue propagate with zero leftover #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wynged merged 1 commit into from
Aug 13, 2025
Merged

continue propagate with zero leftover #1104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Elements.MEP/src/Fittings/StraightSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ public override bool PropagateAdditionalTransform(Transform transform, Transform

if (leftover.IsZero())
{
return false;
// returning true here is a hack to let fittings with multiple
// branches with different offsets continue to propogate their
// transforms. If this returns false it seems that the other
// branches aren't checked.
return true;
}
else
{
Expand Down
Loading