Skip to content

add edge material if there are line elements#1105

Merged
jamesbradleym merged 1 commit into
masterfrom
check-for-lines
Aug 18, 2025
Merged

add edge material if there are line elements#1105
jamesbradleym merged 1 commit into
masterfrom
check-for-lines

Conversation

@jamesbradleym
Copy link
Copy Markdown
Contributor

@jamesbradleym jamesbradleym commented Aug 15, 2025

BACKGROUND:

  • While working on https://github.com/hypar-io/Revit/pull/419 I found that edge materials would not be added unless drawEdges was flagged, which would set up edges on meshes. We don't necessarily want these two concepts entangled.

DESCRIPTION:

  • Checks for line like elements and adds the edge material if they are present.

TESTING:

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@jamesbradleym jamesbradleym requested a review from wynged August 15, 2025 15:32
Copy link
Copy Markdown
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@jamesbradleym jamesbradleym merged commit 8b0c01f into master Aug 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants