docs(ci): scope the native-app target dir comment to the measurement - #148
Open
hyperb1iss wants to merge 1 commit into
Open
docs(ci): scope the native-app target dir comment to the measurement#148hyperb1iss wants to merge 1 commit into
hyperb1iss wants to merge 1 commit into
Conversation
The comment claimed the Tauri bundle step recompiled the whole dependency tree. Sampled runs put it at 157 of roughly 475 crates: the shared third. What remains is the app's own graph, tauri and wry and the platform bindings, which the sidecar build never compiles, so sharing the directory removes duplicated work without moving wall time. Say the measured thing, since the unmeasured version is what sold this change as a speedup in the first place. Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow comment now quantifies crate reuse from the shared ChangesCI documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What this corrects
The comment merged in #146 says the Tauri bundle step "recompiled the whole dependency tree." The sampled runs say a third of it: 157 of roughly 475 crates on both macOS targets. The rest is the Tauri app's own graph (tauri, wry, the platform bindings), which the sidecar build never compiles, so no target directory arrangement can recover it.
The distinction matters because the unmeasured version is exactly what sold #146 as a speedup before the numbers came back flat. The comment now states what was measured and what it buys: less duplicated work, not less wall time.
No behavior change; comment only.
🧪 Verification
actionlintclean.Summary by CodeRabbit