chore(daemon): silence unused warnings in the no-wgpu build - #197
Conversation
The Windows CI job's final step compiles the daemon with --no-default-features --features builtin-drivers, and eleven items used only by wgpu-gated code (display-lane test imports, a top-level DisplayFrameFormat import, a spatial Corner test import, and the extreme-composition bench constants and helpers) warned as unused there. None of the Linux gates build that combo, so the noise only ever showed in the Windows log. Gate the items to match their usages. Verified clean both ways: cargo check --no-default-features --features builtin-drivers --all-targets emits zero warnings, and default-features clippy stays clean. Co-Authored-By: Nova (Claude Fable 5) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 7 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💜 What
Eleven `unused` warnings that only appear when the daemon builds without wgpu — the combo the Windows CI job's daemon-test step uses (`--no-default-features --features builtin-drivers`) — are gated to match their usages. No behavior changes; every edit is a `#[cfg(feature = "wgpu")]` on an import, constant, or bench helper whose only consumers already sit behind that feature.
🔮 Why
None of the Linux gates compile this feature combo, so the warnings live exclusively in the Windows job's log, where they read as new breakage next to unrelated failures. They predate the current PR queue (present on main, visible in every Windows run).
🧪 Verification
`cargo check -p hypercolor-daemon --no-default-features --features builtin-drivers --all-targets` emits zero warnings, and default-features `cargo clippy -p hypercolor-daemon --all-targets` stays clean.
🤖 Generated with Claude Code