fix(satp-hermes): correct add-counterparty-gateway operationId#4341
Open
abhayrajjais01 wants to merge 2 commits into
Open
fix(satp-hermes): correct add-counterparty-gateway operationId#4341abhayrajjais01 wants to merge 2 commits into
abhayrajjais01 wants to merge 2 commits into
Conversation
42cd50f to
f258987
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes the SATP Hermes admin endpoint metadata so the add-counterparty route reports the correct OpenAPI operation ID.
Changes:
- Updates
AddCounterpartyGatewayEndpointV1.getOperationId()to resolveAddCounterpartyfrom the/add-counterparty-gatewayPOST operation. - Aligns operation ID lookup with the endpoint’s existing path and HTTP verb metadata.
Contributor
|
@abhayrajjais01 thank you! Running the tests, please remove the binaries from version control |
Signed-off-by: abhayrajjais01 <abhayraj916146@gmail.com>
65dea34 to
c47a59a
Compare
Contributor
|
@abhayrajjais01 please fix the failing pipelines and follow the new PULL.md and AI guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddCounterpartyGatewayEndpointV1.getOperationId()with the bundled OpenAPI entry forPOST .../add-counterparty-gateway(AddCounterparty).getOperationId()previously readget-sessions-idsGET.operationId, which mislabels the route for authz, metrics, and generated clients.Changes
packages/cactus-plugin-satp-hermes/src/main/typescript/api1/admin/add-counterparty-gateway-endpoint.tsgetOperationId()now resolvesapiPath.post.operationIdfor/api/v1/@hyperledger/cactus-plugin-satp-hermes/add-counterparty-gateway, consistent withgetPath()/getVerbLowerCase().Pull Request Requirements
Character limit