Skip to content

fix(satp-hermes): correct add-counterparty-gateway operationId#4341

Open
abhayrajjais01 wants to merge 2 commits into
hyperledger-cacti:mainfrom
abhayrajjais01:fix/satp-hermes-add-counterparty-operation-id
Open

fix(satp-hermes): correct add-counterparty-gateway operationId#4341
abhayrajjais01 wants to merge 2 commits into
hyperledger-cacti:mainfrom
abhayrajjais01:fix/satp-hermes-add-counterparty-operation-id

Conversation

@abhayrajjais01

Copy link
Copy Markdown
Contributor

Summary

  • Align AddCounterpartyGatewayEndpointV1.getOperationId() with the bundled OpenAPI entry for POST .../add-counterparty-gateway (AddCounterparty).
  • getOperationId() previously read get-sessions-ids GET.operationId, which mislabels the route for authz, metrics, and generated clients.

Changes

File Fix
packages/cactus-plugin-satp-hermes/src/main/typescript/api1/admin/add-counterparty-gateway-endpoint.ts getOperationId() now resolves apiPath.post.operationId for /api/v1/@hyperledger/cactus-plugin-satp-hermes/add-counterparty-gateway, consistent with getPath() / getVerbLowerCase().

Pull Request Requirements

  • Rebased onto upstream/main and squashed into single commit
  • Signed-off-by present (DCO, human only)
  • Conventional Commits format
  • Assisted-by tag (if AI was used)

Character limit

  • PR title and commit subject ≤ 80 characters
  • Commit message body lines ≤ 102 characters

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the SATP Hermes admin endpoint metadata so the add-counterparty route reports the correct OpenAPI operation ID.

Changes:

  • Updates AddCounterpartyGatewayEndpointV1.getOperationId() to resolve AddCounterparty from the /add-counterparty-gateway POST operation.
  • Aligns operation ID lookup with the endpoint’s existing path and HTTP verb metadata.

@RafaelAPB

Copy link
Copy Markdown
Contributor

@abhayrajjais01 thank you! Running the tests, please remove the binaries from version control

Signed-off-by: abhayrajjais01 <abhayraj916146@gmail.com>
@abhayrajjais01 abhayrajjais01 force-pushed the fix/satp-hermes-add-counterparty-operation-id branch 3 times, most recently from 65dea34 to c47a59a Compare July 3, 2026 12:33
@RafaelAPB

Copy link
Copy Markdown
Contributor

@abhayrajjais01 please fix the failing pipelines and follow the new PULL.md and AI guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants