Skip to content

docs: update root references and remove archived docs#4467

Open
ParthSinghPS wants to merge 1 commit into
hyperledger-cacti:mainfrom
ParthSinghPS:docs-cleanup-archived-cacti
Open

docs: update root references and remove archived docs#4467
ParthSinghPS wants to merge 1 commit into
hyperledger-cacti:mainfrom
ParthSinghPS:docs-cleanup-archived-cacti

Conversation

@ParthSinghPS

Copy link
Copy Markdown
Member

This PR supersedes and replaces #4197.

As discussed in the original PR's review by @sandeepnRES and @RafaelAPB, updating the documentation inside docs/docs/cactus/ is unnecessary as it is archived and outdated.

To resolve this cleanly, I have:

  1. Retained @abhigyan1102's URL and naming fixes for the root level CONTRIBUTING.md and CODE_OF_CONDUCT.md.
  2. Completely removed the deprecated docs/docs/cactus/ directory to prevent future contributor confusion.

The original author has been credited via the Co-authored-by tag for their fixes.

Fixes #4197

This PR supersedes and replaces hyperledger-cacti#4197.

As discussed in the original PR's review by @sandeepnRES and @RafaelAPB, updating the documentation inside docs/docs/cactus/ is unnecessary as it is archived and outdated.

To resolve this cleanly, I have:
1. Retained @abhigyan1102's URL and naming fixes for the root level CONTRIBUTING.md and CODE_OF_CONDUCT.md.
2. Completely removed the deprecated docs/docs/cactus/ directory to prevent future contributor confusion.

The original author has been credited via the Co-authored-by tag for their fixes.

Fixes hyperledger-cacti#4197

Co-authored-by: abhigyan1102 <abhigyansingh664@gmail.com>
Signed-off-by: ParthSinghPS <posiedon.1721@gmail.com>

@sandeepnRES sandeepnRES left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at this PR: https://github.com/hyperledger-cacti/cacti/pull/4332/changes
It seems there are references at other places to archived docs.

Would suggest to resolve these before deleting them. Probably moving these commonly referred files into different appropriately named directories, and update references. When nothing else points to the docs/docs/cactus dir being deleted, then it would be fine to delete.

@ParthSinghPS

Copy link
Copy Markdown
Member Author

that is right, i'll work on that and open a separate PR for the links migration soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants