feat(connector-fabric): implement CertDatastore.has() and CertDatastore.delete() methods#4479
Open
abhayrajjais01 wants to merge 2 commits into
Conversation
abhayrajjais01
requested review from
AndreAugusto11,
LordKubaya,
RafaelAPB,
VRamakrishna,
outSH and
sandeepnRES
as code owners
sandeepnRES
reviewed
Jul 1, 2026
abhayrajjais01
force-pushed
the
feat/connector-fabric-cert-datastore-methods
branch
from
b59f3e3 to
c959104
Compare
abhayrajjais01
force-pushed
the
feat/connector-fabric-cert-datastore-methods
branch
3 times, most recently
from
70e660f to
d505ab2
Compare
RafaelAPB
requested changes
Jul 1, 2026
abhayrajjais01
force-pushed
the
feat/connector-fabric-cert-datastore-methods
branch
from
d505ab2 to
d3023dc
Compare
…re.delete() methods Implement the two remaining TODO stubs in CertDatastore by delegating has() and delete() to the keychain instance found via PluginRegistry, matching the existing get/put pattern. Add unit tests with a stateful Map-backed mock keychain that verifies keys are actually stored, queried, and removed. Signed-off-by: abhayraj jaiswal <abhayraj916146@gmail.com>
abhayrajjais01
force-pushed
the
feat/connector-fabric-cert-datastore-methods
branch
2 times, most recently
from
adeb14b to
4463f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CertDatastore.has()andCertDatastore.delete()methods in the Fabric connector datastore.CertDatastoreto allow checking and deleting certificates in keychains.Changes
packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/identity/internal/cert-datastore.tshas()anddelete()stubs by looking up the keychain viaPluginRegistryand delegating the operations.packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/unit/cert-datastore.test.tsget(),put(),has(), anddelete()methods.Pull Request Requirements