Skip to content

ci(satp-hermes): only push to dockerhub on release#4532

Merged
RafaelAPB merged 2 commits into
hyperledger-cacti:mainfrom
RafaelAPB:satp-fix-ci
Jul 7, 2026
Merged

ci(satp-hermes): only push to dockerhub on release#4532
RafaelAPB merged 2 commits into
hyperledger-cacti:mainfrom
RafaelAPB:satp-fix-ci

Conversation

@RafaelAPB

@RafaelAPB RafaelAPB commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficiently and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when, and why.
  • Have git sign-off at the end of the commit message (Signed-off-by: Name <email>) to certify the Developer Certificate of Origin (DCO). Use the -s flag with git commit. See signing commits for more information. AI agents must not add Signed-off-by tags — only the human submitter may certify the DCO (see AI Guidelines §7).
  • Follow the Conventional Commits specification for commit linting.
  • If AI tools were used, include an Assisted-by tag in the commit message per the AI Guidelines §2.2 (e.g., Assisted-by: GitHub-Copilot:claude-opus-4). All AI-generated code must be human-reviewed before submission.
  • Read and followed the Pull Request Guidelines.

Note: PRs that do not satisfy the requirements above will fail the
DCO checker and/or the commit lint CI checks and cannot be merged.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@RafaelAPB RafaelAPB changed the title ci(satp-hermes): remove dev version publish from npmjs ci(satp-hermes): only push to dockerhub on release Jul 3, 2026
@RafaelAPB RafaelAPB enabled auto-merge (rebase) July 3, 2026 12:27
@RafaelAPB RafaelAPB added the IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. label Jul 3, 2026
@RafaelAPB RafaelAPB force-pushed the satp-fix-ci branch 3 times, most recently from 4c022ba to 38a89b3 Compare July 5, 2026 12:04
RafaelAPB added 2 commits July 6, 2026 07:14
Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>
Assisted-by: anthropic:claude-sonnet-4.6

Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>
Comment thread .github/workflows/satp-hermes-release-pipeline.yaml

@sandeepnRES sandeepnRES left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comment

@RafaelAPB RafaelAPB merged commit 87062f8 into hyperledger-cacti:main Jul 7, 2026
131 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants